Skip to content

#1314 Feature Request: Add authenticated webhook notifications - #1317

Merged
lsongsuse merged 1 commit into
neuvector:mainfrom
xingzhang-suse:main
Sep 23, 2026
Merged

lsongsuse merged 1 commit into
neuvector:mainfrom
xingzhang-suse:main

Conversation

@xingzhang-suse

Copy link
Copy Markdown
Collaborator

Description

Fix #1314

Added username and password columns in the webhook table in settings > configuration page and federated configuration page. The password input is used for password.

Screenshot 2026-09-22 at 6 51 55 PM Screenshot 2026-09-22 at 6 52 16 PM Screenshot 2026-09-22 at 6 52 24 PM

In the server side, the username and password are removed from the printed payload log for the webhook.

Test

  1. In the Settings > Configuration page, add or edit webhook with username and password, then submit the configuration form. The username can be shown after refreshing.
  2. In the Federated configuration tab view, add or edit webhook with username and password, then submit. The username can be shown after refreshing. Before the row become editable by the edit button, the input of username and password should be readonly.
  3. In the Settings > Configuration page, the federated webhook can be seen in the table, all the cell of this record should be readonly.

Additional Information

Tradeoff

Potential improvement

@xingzhang-suse
xingzhang-suse requested a review from a team as a code owner September 23, 2026 02:26

@lsongsuse lsongsuse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsongsuse
lsongsuse merged commit f2ad548 into neuvector:main Sep 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add authenticated webhook notifications

2 participants