Skip to content

fix typo in cli (backport) - #1323

Merged
xingzhang-suse merged 2 commits into
neuvector:release/v5.6from
williamlin-suse:william-cli-typo
Sep 28, 2026
Merged

xingzhang-suse merged 2 commits into
neuvector:release/v5.6from
williamlin-suse:william-cli-typo

Conversation

@williamlin-suse

Copy link
Copy Markdown
Contributor

Description

backport from #1294

Fix typos in cli
Do not fix assemblys` should be `assemblies in cli/prog/enforcer.py yet because they are related to REST API spec.

("total_assemblys", "TCP ASM"),
("freed_assemblys", "TCP ASM freed"),

Additional Information

Tradeoff

Potential improvement

@williamlin-suse
williamlin-suse requested a review from a team as a code owner September 28, 2026 21:50
@williamlin-suse
williamlin-suse requested review from holyspectral and removed request for a team September 28, 2026 21:50
@holyspectral
holyspectral requested a lite review from Copilot September 28, 2026 21:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

cli/prog/group.py still contains the value streig typo in its documentation.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Backports CLI typo fixes and corrects related internal identifiers without changing behavior.

Changes:

  • Corrects CLI help text, comments, and messages.
  • Renames misspelled conversation and multipart identifiers.
  • Fixes the conversation module import.
File Description
cli/​prog/​system.py Corrected CLI text and variable names
cli/​prog/​pwd_profile.py Fixed login failure wording
cli/​prog/​policy.py Corrected response-rule text
cli/​prog/​multipart.py Corrected comment wording
cli/​prog/​main.py Fixed conversation module import
cli/​prog/​host.py Corrected help text
cli/​prog/​group.py Fixed identifier and documentation typos
cli/​prog/​diag.py Clarified content-length variable
cli/​prog/​conversation.py Renamed conversation identifiers
cli/​prog/​auth.py Corrected authentication text

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cli/prog/group.py
@holyspectral

Copy link
Copy Markdown
Collaborator

LGTM as long as the copilot finding is fixed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Only non-functional typo, naming, and documentation corrections remain, with no unresolved blocking issues.

Review effort: Lite
Findings: None

Resolved since last review (1)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

@xingzhang-suse xingzhang-suse left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingzhang-suse
xingzhang-suse merged commit 2c184ee into neuvector:release/v5.6 Sep 28, 2026
2 checks passed
@williamlin-suse
williamlin-suse deleted the william-cli-typo branch September 28, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants