Repository navigation
#1314 Feature Request: Add authenticated webhook notifications(Not to submit password while it is empty) - #1329
Merged
Merged
Conversation
…ns(Not to submit password while it is empty)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #1314
For local webhook, set the password as null while it is empty. It will not be included into the payload for the request. The backend will treat the password is unchanged.
For the federated webhook, the logic is handled already.
Test
Go to the webhook section, add a new one without password, it should be able to be submitted.
Update the webhook without fill the password, it should be able to be submitted, and the password in the backend should not be changed into empty.
Additional Information
Tradeoff
Potential improvement