Skip to content

Add .wrl support - #185

Open
Toctave wants to merge 3 commits into
neverhood311:masterfrom
Toctave:master
Open

Add .wrl support#185
Toctave wants to merge 3 commits into
neverhood311:masterfrom
Toctave:master

Conversation

@Toctave

@Toctave Toctave commented Dec 7, 2023

Copy link
Copy Markdown

As the title says, this PR adds basic WRL support. I've done only the bare minimum, so there aren't any import options for instance. That being said, in the long run it would perhaps be better to somehow inherit the import UI from each import format rather than recreating it in the add-on.

@Toctave Toctave changed the title Add .x3d/.wrl support Add .wrl support Dec 7, 2023
@neverhood311

Copy link
Copy Markdown
Owner

What's the difference between WRL and X3D? Why did you remove all mentions of X3D? (I'm most familiar with OBJ, PLY, and STL, so I don't know much about X3D)

@Toctave

Toctave commented Dec 7, 2023

Copy link
Copy Markdown
Author

I don't really know the difference actually (not an X3D expert either, I just wrote this change for a coworker who needed to visualize .wrl sequences).

Blender has the same importer for both file extensions, hence why I initially mentioned "X3D/WRL" everywhere, but due to how your add-on currently scans for files I needed to have a single file extension, hence I figured I'd go with .wrl everywhere first and then maybe add .x3d back in.

I'll give the X3D/WRL thing a quick look and let you know.

@neverhood311

Copy link
Copy Markdown
Owner

Blender has the same importer for both file extensions, hence why I initially mentioned "X3D/WRL" everywhere, but due to how your add-on currently scans for files I needed to have a single file extension, hence I figured I'd go with .wrl everywhere first and then maybe add .x3d back in.

Interesting. That's a good catch

Also, I've already added this feature (x3d at least) to v2.2.0. See #144. You might want to start your branch from there instead of from master.

@Toctave

Toctave commented Dec 8, 2023

Copy link
Copy Markdown
Author

Oh, ok, thanks! How come the branch with the most recent changes is not the default one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants