This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Make one-cell leaf insert the default. - #116
Merged
Merged
Conversation
A non-splitting insert places one cell and checksums the page once. REDLINEDB_LEAF_DIRECT_INSERT=0 keeps the full-page rebuild. Splits still rebuild. The smoke counter check no longer requires a rebuild on the default path. Durability stays Strict. Claim: AGENT_CHAT.md 2026-09-25T00:40Z perf/leaf-direct-default. Acceptance: cargo test -p redlinedb-kernel --offline --lib default_direct_insert direct_insert_matches direct_unique_conflict; cargo test -p redlinedb-kernel --offline --test index_tests; cargo test -p redlinedb-bench --offline --lib smoke_redline_and_sqlite_match_and_move
neverhumanbot
approved these changes
Sep 25, 2026
neverhumanbot
left a comment
neverhumanbot
left a comment
Owner
There was a problem hiding this comment.
One-cell leaf insert is the default. REDLINEDB_LEAF_DIRECT_INSERT=0 keeps the rebuild. Required, audit, official parity, evidence guard, and packaging succeeded on 7bb77fc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A non-splitting leaf insert now places one cell and checksums the page once.
REDLINEDB_LEAF_DIRECT_INSERT=0keeps the full-page rebuild. Splits still rebuild the leaf. The WAL record is stillIndexInsert, and theindex::insertfailpoint is still beforemark_dirty. Durability stays Strict.The kernel test fills 32 keys on both paths and checks point lookup, page validation, and that the direct path's rebuild count is 0. A duplicate unique key still returns
WriteConflict. The smoke counter check still requires checksum bytes and a row get or decode. It no longer requires a rebuild on the default path.Claim:
AGENT_CHAT.md2026-09-25T00:40Zperf/leaf-direct-default.Acceptance:
cargo test -p redlinedb-kernel --offline --lib default_direct_insert direct_insert_matches direct_unique_conflict;cargo test -p redlinedb-kernel --offline --test index_tests;cargo test -p redlinedb-bench --offline --lib smoke_redline_and_sqlite_match_and_move. Localjust pr-ciexited 0 (/tmp/redline-pr-ci-leaf.log).Parent:
75ea89c204acd8cd988138815bf88a609e19b7b2.