This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Close three kernel gates the benchmark notes flagged. - #119
Merged
Merged
Conversation
A clean page whose clock usage has saturated can be evicted. A new row-lock caller does not take a free row ahead of a waiter already queued, and a spurious wake does not grant the lock to anyone but the front. A morsel arena offset that does not fit in u32 aborts instead of truncating. An exact WAL segment fill stays within the configured length. Claim: AGENT_CHAT.md 2026-09-25T18:40Z fix/kernel-p0-gates. Acceptance: cargo test -p redlinedb-kernel --offline --lib newcomer_does_not_cut fifo_handoff; cargo test -p redlinedb-kernel --offline --test storage_tests buffer_pool_evicts_a_clean_frame; cargo test -p redlinedb-kernel --offline --test wal_tests exact_segment_fill; cargo test -p redlinedb-sql --offline --lib an_offset_past_u32
neverhumanbot
approved these changes
Sep 25, 2026
neverhumanbot
left a comment
Owner
There was a problem hiding this comment.
Clock eviction, row-lock FIFO, and morsel arena bounds. Exact WAL segment fill stays inside the limit. Required, audit, official parity, evidence guard, and packaging succeeded on 85bbec3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ideas taken from the kernel benchmark battletest that were still true in the tree, as tests and fixes. No speed ratio is claimed. Durability stays Strict.
wal_pipelinestays off.u32aborts instead of truncating the stored offset in release builds.Not in this pull request: one-pass scan loads, positional I/O, physical WAL batching, route-versus-index admission, and any suite median. Those are later measurements on the official Normal lane.
Claim:
AGENT_CHAT.md2026-09-25T18:40Zfix/kernel-p0-gates.Acceptance:
cargo test -p redlinedb-kernel --offline --lib newcomer_does_not_cut fifo_handoff;cargo test -p redlinedb-kernel --offline --test storage_tests buffer_pool_evicts_a_clean_frame;cargo test -p redlinedb-kernel --offline --test wal_tests exact_segment_fill;cargo test -p redlinedb-sql --offline --lib an_offset_past_u32. Localjust pr-ciexited 0 (/tmp/redline-pr-ci-p0.log).Parent:
76ba2a52c469c8917929418ff1f4fe8f5b6623cf.