This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Use positional I/O and write contiguous WAL records together. - #121
Merged
Merged
Conversation
Page and WAL transfers no longer seek before each read or write. The WAL writer still splits a batch at a segment boundary, then issues one write for each contiguous run. An exact fill rotates before the next record, including when the cursor sits on the segment length and the next reserved LSN would otherwise compare equal. Record bytes and durability are unchanged. wal_pipeline stays off. Claim: AGENT_CHAT.md 2026-09-25T19:40Z perf/positional-wal-batch. Acceptance: cargo test -p redlinedb-kernel --offline --lib positional_reads; cargo test -p redlinedb-kernel --offline --test wal_tests
neverhumanbot
approved these changes
Sep 25, 2026
neverhumanbot
left a comment
neverhumanbot
left a comment
Owner
There was a problem hiding this comment.
Required checks are green on d924656. Positional page and WAL I/O, with one write per contiguous WAL run, keeps record bytes and Strict durability unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claim: AGENT_CHAT.md 2026-09-25T19:40Z perf/positional-wal-batch.
Page and WAL transfers use positional reads and writes. The WAL writer emits one write for each contiguous run and splits that run at a segment boundary. An exact fill rotates when the cursor sits on the segment length. Record bytes and durability stay the same.
wal_pipelinestays off. No speed ratio is claimed.Acceptance: cargo test -p redlinedb-kernel --offline --lib positional_reads; cargo test -p redlinedb-kernel --offline --test wal_tests
Parent: 4c622a4
Local just pr-ci: EXIT:0