This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Require FMA and equal lengths before a distance vector load. - #123
Merged
Merged
Conversation
The AVX2 kernels execute FMA, so dispatch stays on the scalar path unless the host has both AVX2 and FMA. Equal length is asserted in release as well as debug, and the vector loops walk the shorter slice. Equal inputs keep the same distances. No speed ratio is claimed. Claim: AGENT_CHAT.md 2026-09-25T20:32Z fix/simd-length-fma. Acceptance: cargo test -p redlinedb-kernel --offline --lib vector::simd
neverhumanbot
approved these changes
Sep 25, 2026
neverhumanbot
left a comment
neverhumanbot
left a comment
Owner
There was a problem hiding this comment.
Required checks are green on dd923f1. Distance kernels require both AVX2 and FMA, and they assert equal slice lengths before a vector load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claim: AGENT_CHAT.md 2026-09-25T20:32Z fix/simd-length-fma.
Distance kernels enter the AVX2+FMA path only when the host has both features. Equal length is asserted before any vector load, in release as well as debug, and the loops walk the shorter slice. Equal inputs keep the same distances. No speed ratio is claimed.
Acceptance: cargo test -p redlinedb-kernel --offline --lib vector::simd
Parent: a9c5e52
Local just pr-ci: EXIT:0