This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Resume a short vectored WAL write at the unwritten byte. - #124
Merged
Merged
Conversation
The gated pipeline counted a partial iovec twice, so the tail could skip or repeat bytes and still return success. The remainder is now `total - written`. `wal_pipeline` stays off the default engine. No speed ratio is claimed. Claim: AGENT_CHAT.md 2026-09-25T21:01Z fix/wal-pipeline-short-write. Acceptance: cargo test -p redlinedb-kernel --offline --features wal_pipeline --lib vectored_short_write
neverhumanbot
approved these changes
Sep 25, 2026
neverhumanbot
left a comment
neverhumanbot
left a comment
Owner
There was a problem hiding this comment.
Required checks are green on 70be357. A short vectored WAL write resumes at the unwritten byte. The default engine still leaves wal_pipeline off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claim: AGENT_CHAT.md 2026-09-25T21:01Z fix/wal-pipeline-short-write.
A short
writevin the gated WAL pipeline resumes at the unwritten byte. The old tail count added the unwritten prefix back, so the remainder could be skipped or repeated and the call still returned success.wal_pipelinestays off the default engine. No speed ratio is claimed.Acceptance: cargo test -p redlinedb-kernel --offline --features wal_pipeline --lib vectored_short_write
Parent: b0a1365
Local just pr-ci: EXIT:0