Wrong Number of Slices and Times#45
Merged
Merged
Conversation
The 'init_PliReader()' static method of the 'PliReader' class has been updated in the way it extracts the number of slices from the .pli file. This is done by reading the 'ISLICE' value; depending on its value, the number of slices is calculated as 'M3'+1, if 'ISLICE' is 0, or as 'M3', if 'ISLICE' is 1, where the 'M3' value is found in the .pli file as well. The 'ISLICE' is read as a string; however, previously, it was compared with an integer value, thus preventing to correctly identify the number of slices. Now, the 'ISLICE' value is compared with a string, thus solving the identified issue. By properly identifying the number of slices, also the problem on the missing time instants for the radially dependent quantities is solved; in fact, the extraction of these times from the .mac file is directly tied to the number of slices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
init_PliReader()static method of thePliReaderclass has been updated in the way it extracts the number of slices from the .pli file. This is done by reading theISLICEvalue as a string; however, previously, it was compared with an integer value, thus preventing to correctly identify the number of slices.Now, the
ISLICEvalue is transformed into an integer to check if "truthy" or not: this solves the highlighted issue.In addition, by properly identifying the number of slices, also the problem on the missing time instants for the radially dependent quantities is solved; in fact, the extraction of these times from the .mac file is directly tied to the number of slices.