fix: promote StreamingService to foreground immediately on Android 8+#408
Open
7MS8 wants to merge 1 commit into
Open
fix: promote StreamingService to foreground immediately on Android 8+#4087MS8 wants to merge 1 commit into
7MS8 wants to merge 1 commit into
Conversation
On GrapheneOS (and strictly enforced Android 12+), the 5-second window for calling startForeground() was being missed because StreamingService extended IntentService, which ran startForeground() on a background worker thread with non-deterministic scheduling delay. Convert StreamingService from deprecated IntentService to Service: - Call startForeground() in onStartCommand() on the main thread, guaranteeing foreground promotion before any background-process limits can apply - Run the blocking waitFor() in a dedicated thread - Return START_NOT_STICKY (user-initiated serve, no auto-restart) - Add tryStartForegroundService() to ActivityHelper and use it for all StreamingService start calls Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #406 per reviewer request (separate unrelated fixes into their own PRs).
Bug
On GrapheneOS (and strictly enforced Android 12+), streaming/opening a file could silently fail.
StreamingServiceextendedIntentService, which runsstartForeground()on a background worker thread with non-deterministic scheduling delay. If that delay exceeds the ~5s the platform allows before killing the process, GrapheneOS kills the service before it ever reaches the foreground.Fix
Convert
StreamingServicefrom the deprecatedIntentServiceto a plainService:startForeground()inonStartCommand()on the main thread, guaranteeing foreground promotion before any background-process limits can apply.waitFor()in a dedicated thread instead.START_NOT_STICKY(user-initiated serve, no auto-restart).tryStartForegroundService()toActivityHelperand use it for allStreamingServicestart calls.Reproduction
masterprior to this fix (versionCode410/417).Test plan
./gradlew :app:compileOssDebugSources).