Skip to content

fix: stop forcing size-only sync comparisons via RCLONE_LOCAL_NO_SET_MODTIME #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7MS8 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: stop forcing size-only sync comparisons via RCLONE_LOCAL_NO_SET_MODTIME #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/src/main/java/ca/pkay/rcloneexplorer/Rclone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,17 @@ public String[] getRcloneEnv(String... overwriteOptions) {
String tmpDir = context.getCacheDir().getAbsolutePath();
environmentValues.add("TMPDIR=" + tmpDir);

// ignore chtimes errors
// ref: https://github.com/rclone/rclone/issues/2446
environmentValues.add("RCLONE_LOCAL_NO_SET_MODTIME=true");
// RCLONE_LOCAL_NO_SET_MODTIME used to be set here to work around chtimes
// crashes on old Android storage stacks (ref: rclone#2446). It makes the
// local backend's Precision() report ModTimeNotSupported unconditionally
// (backend/local/local.go), which makes rclone's default file comparison
// fall back to a silent size-only check for every sync, ignoring
// modification time entirely -- changed files of the same size never get
// re-synced. A failing chtimes() is not fatal in current rclone: a failed
// SetModTime is just logged and counted as an error, the transfer itself
// still succeeds (fs/operations/operations.go). So leave modtime-setting
// enabled and let rclone's own runtime precision probe (readPrecision())
// degrade gracefully per-remote if chtimes truly isn't supported there.

// Allow the caller to overwrite any option for special cases
Iterator<String> envVarIter = environmentValues.iterator();
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/ca/pkay/rcloneexplorer/RcloneRcd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,9 @@ public String[] getEnv() {
String tmpDir = context.getCacheDir().getAbsolutePath();
environmentValues.add("TMPDIR=" + tmpDir);

// ignore chtimes errors
// ref: https://github.com/rclone/rclone/issues/2446
environmentValues.add("RCLONE_LOCAL_NO_SET_MODTIME=true");
// See Rclone.java getRcloneEnv() for why RCLONE_LOCAL_NO_SET_MODTIME is
// deliberately not set here: it forces rclone's local-backend file
// comparison to silently ignore modification time (size-only fallback).
return environmentValues.toArray(new String[0]);
}

Expand Down