Repository navigation
Rename market symbol filter to market_id; render market_id on articles - #5
Merged
Merged
Conversation
Sync with python-client: the get_market_news and get_market_counts tools now take market_id instead of symbol. SYMBOL_FILTER becomes MARKET_ID_FILTER. The old filter was removed upstream, so no alias is kept. The article formatter also renders market_id, which the API returns alongside symbol. Both are separate response fields and both are shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs this client with the python-client market update (PRs #24–#26).
Request filter
The
/marketand/market/countendpoints now takemarket_idinstead ofsymbol. The old filter was removed upstream (62c4f80 removed symbol filter from market endpoints), so no back-compat alias is kept — this is a breaking change for anyone passingsymbol.Verification
Full test suite passes. Note the published
openapi.jsonis stale: it still documentssymboland has nomarket_id, so it could not be used to verify this change.Tool surface
get_market_newsandget_market_countsnow takemarket_id;SYMBOL_FILTERbecomesMARKET_ID_FILTER. Docstrings, examples and the README are updated.Response rendering
The API returns both
symbolandmarket_idon market articles. The formatter now rendersmarket_idalongside the existingsymbolsline — labelled exactly as the API names it, so the model reads the same name it must pass back as a filter.