Skip to content

Include MACOS arm64 compatibility in manage.sh #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwaiton wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Include MACOS arm64 compatibility in manage.sh #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d26287b
Include arm64 architecture support for miniconda installation
jwaiton Feb 18, 2025
b65a4b4
Add test for conda installation on arm
jwaiton Feb 19, 2025
b22a30d
Alter logic and include linux based arm support
jwaiton Feb 20, 2025
75881b1
Reintroduce tests with altered conda path and fix typo
jwaiton Feb 20, 2025
977eb1f
add linux-based arm compatibility
jwaiton Feb 21, 2025
6b8e3f6
include environment variables for conda activation
jwaiton Feb 21, 2025
7eb5d99
alter test_suite.yml to include arm architectures
jwaiton Feb 21, 2025
6b460e6
alter logic for arm based tests
jwaiton Feb 21, 2025
7d87986
remove redundant tests
jwaiton Feb 21, 2025
d5c8687
include `${ARCH}` into miniconda installation
jwaiton Jan 21, 2026
04719f4
make the GHA conda hack even hackier
jwaiton Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/test_suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
matrix:
python-version: [3.8]
#platform: [ubuntu-18.04, macos-latest]
platform: [ubuntu-24.04]
platform: [ubuntu-24.04, macos-latest, ubuntu-24.04-arm]
runs-on: ${{ matrix.platform }}

steps:
Expand All @@ -26,10 +26,19 @@ jobs:
# if: runner.os == 'macOS'

- name: HACK! remove default conda
run: sudo unlink /usr/bin/conda
run: |
set +e # allow this step to fail for differing architectures/missing condas
sudo unlink /usr/bin/conda
set -e # reset

- name: Install IC
run: |

case "$(uname -m)" in
x86_64) source $CONDA/etc/profile.d/conda.sh ;;
aarch64) echo "CONDA=/home/runner/miniconda" >> "$GITHUB_ENV" ;;
arm64) echo "CONDA=/Users/runner/miniconda" >> "$GITHUB_ENV" ;;
esac
source manage.sh work_in_python_version_no_tests ${{ matrix.python-version }}

- name: Run tests
Expand Down
17 changes: 16 additions & 1 deletion manage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,26 @@ function install_conda {
;;
esac

# Setting architecture based on input
ARCH=$(uname -m)

case $ARCH in

x86_64) : ;;
arm64) : ;;
aarch64) : ;;
*)
echo "Installation only supported on x86_64 and arm architectures"
exit 1
;;
esac


if conda --version ; then
echo Conda already installed. Skipping conda installation.
else
echo Installing conda for $CONDA_OS
CONDA_URL="https://repo.anaconda.com/miniconda/Miniconda3-py${PYTHON_VERSION//.}_23.11.0-2-${CONDA_OS}-x86_64.sh"
CONDA_URL="https://repo.anaconda.com/miniconda/Miniconda3-py${PYTHON_VERSION//.}_23.11.0-2-${CONDA_OS}-${ARCH}.sh"
if which wget; then
wget ${CONDA_URL} -O miniconda.sh
else
Expand Down
Loading