Adapt to NC34+ comments#1095
Merged
Merged
Conversation
tcitworld
force-pushed
the
fix/nextcloud-34-compat
branch
3 times, most recently
from
4e2456d to
483ec3a
Compare
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
…unt it each time Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
fix/nextcloud-34-compat
branch
from
483ec3a to
e2f46cd
Compare
6 tasks
Contributor
|
Its a bug in server 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments style is missing since nextcloud/server#58353 on NC34.
Also, mounting the commentsView each time breaks the sidebar when switching announcement, which is fixed in the second commit.