Move to typed properties and IInitialState #4282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Jun 13, 2022
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Thoughts and prayers for the backport bot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4282 +/- ##
============================================
- Coverage 23.31% 22.87% -0.44%
Complexity 442 442
============================================
Files 247 247
Lines 11444 11369 -75
Branches 1923 1923
============================================
- Hits 2668 2601 -67
+ Misses 8776 8768 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tcitworld
force-pushed
the
typed-properties
branch
2 times, most recently
from
40d843c to
d49b15e
Compare
Member
|
conflicts mildly |
miaulalala
force-pushed
the
typed-properties
branch
from
d49b15e to
977cc94
Compare
Contributor
And a few extras Signed-off-by: Thomas Citharel <tcit@tcit.fr>
miaulalala
force-pushed
the
typed-properties
branch
from
b211fc7 to
386c226
Compare
Contributor
|
|
Contributor
|
@tcitworld I would mind accepting this, would you be willing to rebase this PR? |
Member
Author
|
I won't have the time to go though with this, anyone can feel free to take over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a few extras
Needs #4279