Hide e-mail controls in calendar when e-mail sending is disabled #4386
Conversation
This mod hides `Send email` checkbox from attendee context menu if `dav.sendInvitations` is disabled. It also replaces misleading status message about invitations already sent when adding attendee to event. Author-Change-Id: IB#1121918 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
tcitworld
requested review from
ChristophWurst,
JuliaKirschenheuter,
miaulalala,
st3iny and
tcitworld
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
============================================
+ Coverage 29.42% 29.47% +0.04%
Complexity 330 330
============================================
Files 220 220
Lines 7702 7706 +4
Branches 1019 1017 -2
============================================
+ Hits 2266 2271 +5
+ Misses 5436 5435 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We may want to display a message on top of the attendee list: « Sending e-mail invitations to attendees is disabled by the administrator » |
|
PHP tests fail :/ also, you can lint the code base by calling Thanks for the PR! |
Author-Change-Id: IB#1121918 Fixes: 0cc44d4 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Different topic; feel free to implement this separately.
Fixed in 36f93cd. Please verify (not experienced in nextcloud devel). |
| organizerName: this.organizerDisplayName, | ||
| }), | ||
| } | ||
| return { |
There was a problem hiding this comment.
Could you briefly explain why the check for the isViewedByOrganiser isn't needed any more?
There was a problem hiding this comment.
Could you briefly explain why the check for the isViewedByOrganiser isn't needed any more?
Without this fix, when you create an appointment, calendar will display "Invitation sent" just after attendee is added, before any messages are sent/event saved. This is misleading.
There was a problem hiding this comment.
Yes that is true, but the visibility of the email sending status for the organizer only should still be kept in.
There was a problem hiding this comment.
Nextcloud should not lie to user (now it lies that invitation was sent even before event is saved and before sending may take place; more - it also lies about sent invitation if sending invitations is disabled in Nextcloud...). Nextcloud cannot state that invitation was not sent (i.e. when sending invitations is disabled in Nextcloud) because external client (like Thunderbird) could have done it already. Solution proposed here sounds most reasonably for us. Changing it requires more work (i.e. update status after message was actually sent by Nextcloud) and is outside of scope of this PR.
There was a problem hiding this comment.
That is not what I'm talking about at all, I agree with you on having a correct state on the email sending. I am talking about the VISIBILITY of the element. It should only be visible to the Organizer of the event. I cannot find this limitation in your code as you have removed it. Does your new code cover this visibility issue in a different way or does this revert previous work?
There was a problem hiding this comment.
Does your new code cover this visibility issue in a different way or does this revert previous work?
After this PR organizer sees same message as any other user ("Has not responded to {organizerName}'s invitation yet").
There was a problem hiding this comment.
ok then this code change will remove the limitation. I would ask you to please take a look at the old code and add this back in in a way that works with your changes. @st3iny can you also please have a look at this?
There was a problem hiding this comment.
This PR displays "Has not responded to..." for ALL users so no need for PR to be updated (code from else was simply moved outside of removed if/else).
|
Closing this as this is no longer relevant. All function related to email are automatically disabled when no email is setup |
|
Yes, but this PR is still relevant. It is about disabling the option to send emails to invitees if disabled on the backend (RSVP attribute of ATTENDEE properties). |
7 participants
This mod hides
Send emailcheckbox from attendee context menu ifdav.sendInvitationsis disabled. It also replaces misleading statusmessage about invitations already sent when adding attendee to event.
Author-Change-Id: IB#1121918
Signed-off-by: Pawel Boguslawski pawel.boguslawski@ib.pl