Skip to content

Conversation

@hamza221
Copy link
Contributor

fix #4092

@hamza221 hamza221 self-assigned this Mar 31, 2023
@hamza221 hamza221 added 3. to review Waiting for reviews bug labels Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (236a14a) 22.36% compared to head (a6823ac) 22.35%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5122      +/-   ##
============================================
- Coverage     22.36%   22.35%   -0.01%     
  Complexity      359      359              
============================================
  Files           236      236              
  Lines         11554    11557       +3     
  Branches       2250     2250              
============================================
  Hits           2584     2584              
- Misses         8970     8973       +3     
Flag Coverage Δ
javascript 14.00% <0.00%> (-0.01%) ⬇️
php 64.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/AppointmentConfigModal.vue 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. See the pending discussion.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this

@hamza221
Copy link
Contributor Author

hamza221 commented May 4, 2023

what about codecov should we ignore it ? I'll fix the conflicts rn

@hamza221 hamza221 force-pushed the bug/replace-calendar branch from d5b035f to 8c78e51 Compare May 4, 2023 15:09
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the bug/replace-calendar branch from 8c78e51 to a6823ac Compare June 18, 2023 16:00
@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 18, 2023
@SebastianKrupinski
Copy link
Contributor

@hamza221 is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to replace deleted appointment target calendar

5 participants