Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Sep 25, 2025

Partially addresses #5906 (review)

Move the simple editor actions menu to the bottom. This looks a lot cleaner, IMO. As requested by our designers.

Screenshots

Creating a new event

Screenshot_20250925_124357

Viewing my own event

Screenshot_20250925_124613

Viewing an invitation

Screenshot_20250925_124418

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny requested a review from nimishavijay September 25, 2025 10:47
@st3iny st3iny self-assigned this Sep 25, 2025
@st3iny st3iny added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor labels Sep 25, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.56%. Comparing base (f189e36) to head (753491d).
⚠️ Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
src/views/EditSimple.vue 0.00% 41 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7491   +/-   ##
=======================================
  Coverage   13.56%   13.56%           
=======================================
  Files         218      218           
  Lines       11329    11327    -2     
  Branches     2710     2708    -2     
=======================================
  Hits         1537     1537           
+ Misses       9432     9430    -2     
  Partials      360      360           
Flag Coverage Δ
javascript 13.56% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. all works good.

@SebastianKrupinski
Copy link
Contributor

@st3iny my only comment would be to cluster all the buttons at the bottom right.

3 dot menu - More Details - Edit

But its not a blocker

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @SebastianKrupinski ! We can always have the more details button next to the primary action, and then everything else :)

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor feedback-requested

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

4 participants