-
Notifications
You must be signed in to change notification settings - Fork 279
feat: move simple editor actions to the bottom #7491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7491 +/- ##
=======================================
Coverage 13.56% 13.56%
=======================================
Files 218 218
Lines 11329 11327 -2
Branches 2710 2708 -2
=======================================
Hits 1537 1537
+ Misses 9432 9430 -2
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SebastianKrupinski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. all works good.
|
@st3iny my only comment would be to cluster all the buttons at the bottom right. 3 dot menu - More Details - Edit But its not a blocker |
nimishavijay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @SebastianKrupinski ! We can always have the more details button next to the primary action, and then everything else :)
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Partially addresses #5906 (review)
Move the simple editor actions menu to the bottom. This looks a lot cleaner, IMO. As requested by our designers.
Screenshots
Creating a new event
Viewing my own event
Viewing an invitation