-
Notifications
You must be signed in to change notification settings - Fork 279
feat: Reusable duration selector #7560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
TODO: Fix visual glitch with NcSelect Done |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7560 +/- ##
==========================================
- Coverage 10.88% 10.86% -0.02%
==========================================
Files 327 328 +1
Lines 62920 63042 +122
Branches 902 903 +1
==========================================
+ Hits 6847 6848 +1
- Misses 55934 56055 +121
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
92276c6 to
6ce17cb
Compare
Is that still to do? |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early feedback
8e453bd to
022af9a
Compare
Nope, this is dealt with |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
022af9a to
3eddeea
Compare
Then please mark it as such |
|
@ChristophWurst ^^ can we remove the block now |
Summary
Predefined options

Custom options
