Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Oct 10, 2025

Summary

  • Added reusable duration selector with predefined duration and custom duration, supports minute and iso8601 duration format input and output

Predefined options
image

Custom options
image

@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Oct 10, 2025

TODO: Fix visual glitch with NcSelect

Done

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 0.44444% with 224 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.86%. Comparing base (78a507e) to head (3eddeea).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/DurationSelector.vue 0.50% 196 Missing ⚠️
src/views/Proposal/ProposalEditor.vue 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7560      +/-   ##
==========================================
- Coverage   10.88%   10.86%   -0.02%     
==========================================
  Files         327      328       +1     
  Lines       62920    63042     +122     
  Branches      902      903       +1     
==========================================
+ Hits         6847     6848       +1     
- Misses      55934    56055     +121     
  Partials      139      139              
Flag Coverage Δ
javascript 10.86% <0.44%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch 3 times, most recently from 92276c6 to 6ce17cb Compare October 10, 2025 22:36
@ChristophWurst
Copy link
Member

TODO: Fix visual glitch with NcSelect

Is that still to do?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early feedback

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch from 8e453bd to 022af9a Compare November 4, 2025 19:51
@SebastianKrupinski
Copy link
Contributor Author

TODO: Fix visual glitch with NcSelect

Is that still to do?

Nope, this is dealt with

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch from 022af9a to 3eddeea Compare November 4, 2025 19:53
@ChristophWurst
Copy link
Member

Nope, this is dealt with

Then please mark it as such

@SebastianKrupinski
Copy link
Contributor Author

@ChristophWurst ^^ can we remove the block now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants