Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 5, 2025

Details

From https://stable8--nextcloud-vue-components.netlify.app/

Import from a single root is available as well. Use with caution: this might lead to slower build time and larger bundles in some cases.

The appointments scripts are small and standalone. They use a few nextcloud/vue components. On main we include the full nextcloud/vue. It will not be tree shaken.

Comparison

Before

Entrypoints:
  main (5.64 MiB)
      calendar-main.js?v=a7305326cd103dfb1881
  contacts-menu (333 KiB)
      calendar-contacts-menu.js?v=9003c166b073eb6859e5
  appointments-booking (3.48 MiB)
      calendar-appointments-booking.js?v=30b2a188baa1c9f0c8e3
  appointments-confirmation (403 KiB)
      calendar-appointments-confirmation.js?v=09c94c3f873574961d8d
  appointments-conflict (403 KiB)
      calendar-appointments-conflict.js?v=5b98e8588590912beb50
  appointments-overview (3.17 MiB)
      calendar-appointments-overview.js?v=601d743edc8ea917e84b
  proposal-public (1.99 MiB)
      calendar-proposal-public.js?v=6bae3689fb176fc337c9

After

Entrypoints:
  main (5.64 MiB)
      calendar-main.js?v=c69cd9e13409ea3714ea
  contacts-menu (333 KiB)
      calendar-contacts-menu.js?v=7ef629f700fce7391355
  appointments-booking (1.35 MiB)
      calendar-appointments-booking.js?v=a8191000967f91886fdf
  appointments-confirmation (403 KiB)
      calendar-appointments-confirmation.js?v=09c94c3f873574961d8d
  appointments-conflict (403 KiB)
      calendar-appointments-conflict.js?v=5b98e8588590912beb50
  appointments-overview (3.17 MiB)
      calendar-appointments-overview.js?v=601d743edc8ea917e84b
  proposal-public (1.99 MiB)
      calendar-proposal-public.js?v=22fba3be8899be9df924

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.88%. Comparing base (78a507e) to head (6bbcd2a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/views/Appointments/Booking.vue 0.00% 6 Missing ⚠️
src/components/Appointments/AppointmentDetails.vue 0.00% 4 Missing ⚠️
...ts/Appointments/AppointmentBookingConfirmation.vue 0.00% 1 Missing ⚠️
src/components/Appointments/AppointmentSlot.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7671      +/-   ##
==========================================
- Coverage   10.88%   10.88%   -0.01%     
==========================================
  Files         327      327              
  Lines       62920    62928       +8     
  Branches      902      902              
==========================================
  Hits         6847     6847              
- Misses      55934    55942       +8     
  Partials      139      139              
Flag Coverage Δ
javascript 10.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a lint as well


<script>
import { NcEmptyContent as EmptyContent } from '@nextcloud/vue'
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used as EmptyContent, not NcEmptyContent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants