Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 8, 2025

Bumps teamtnt/tntsearch from 5.0.0 to 5.0.2.

Release notes

Sourced from teamtnt/tntsearch's releases.

minor fixes

No release notes provided.

v5.0.1

What's Changed

Full Changelog: teamtnt/tntsearch@v5.0.0...v5.0.1

Commits
  • 7ee319d PS5 :D
  • 058e39a Merge pull request #356 from leonardfischer/clean-up-code
  • ded3dd5 Clean up code, based on PSALM suggestions
  • fb20773 Merge pull request #348 from leonardfischer/update-php-requirement-in-readme
  • d21a1e7 Merge pull request #351 from leonardfischer/create-mariadb-driver-alias
  • 0016594 Merge pull request #353 from leonardfischer/improve-german-stopwords
  • a12c404 Merge pull request #354 from leonardfischer/refactor-code-to-be-more-readable
  • c855a44 Merge pull request #355 from leonardfischer/avoid-deprecated-message-for-null...
  • 19d9694 Add test cases for tokenizer to handle invalid values without error
  • e7f9181 Only 'tokenize' if given value is scalar, use string casting
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 8, 2025

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@max-nextcloud max-nextcloud force-pushed the dependabot/composer/teamtnt/tntsearch-5.0.2 branch from 1d58d4d to 88a47cb Compare September 8, 2025 07:33
@max-nextcloud
Copy link
Collaborator

I fixed some easy breakages... But these are not trivial for me:

image

On the tntsearch side of things only the types have been added:

teamtnt/tntsearch@eb5803c#diff-365b5f87c254f636d809d1a2b51db3b272ef8d1bb6c6a4fa5cf524e0e8197253

And it looks like we accessed the properties before but psalm did not notice.

The overwriting of config['storage'] is necessary so we can have a temporary database (sqlite:) despite tntsearch trying to appent a / to the url:

https://github.com/teamtnt/tntsearch/blob/7ee319d9d96a043164571eab87db72071014d66b/src/Engines/SqliteEngine.php#L132

@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Sep 8, 2025

Cleanest way out maybe is to create a subclass of the SqliteEngine that uses a temp storage and also implements our custom stuff that we do with engine->index.

The engine class can be handed to TNTSearch as part of the config.

https://github.com/teamtnt/tntsearch/blob/7ee319d9d96a043164571eab87db72071014d66b/src/TNTSearch.php#L47-L56

Bumps [teamtnt/tntsearch](https://github.com/teamtnt/tntsearch) from 5.0.0 to 5.0.2.
- [Release notes](https://github.com/teamtnt/tntsearch/releases)
- [Changelog](https://github.com/teamtnt/tntsearch/blob/master/CHANGELOG.md)
- [Commits](teamtnt/tntsearch@v5.0.0...v5.0.2)

---
updated-dependencies:
- dependency-name: teamtnt/tntsearch
  dependency-version: 5.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the dependabot/composer/teamtnt/tntsearch-5.0.2 branch from 88a47cb to cd17e36 Compare September 8, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants