feat: Add expiry date support for collective shares in backend #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
reviewed
Dec 2, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Looks really good already. I have left some remarks.
silverkszlo
force-pushed
the
1566-public-shares-inherit-default-expiry-date-from-file-shares
branch
from
a318b5c to
19476f0
Compare
Add ability to view and manage expiration dates on collective shares. Shares now inherit and respect Nextcloud's default expiry date policy for file shares. - Add expirationDate field to CollectiveShare entity (transient) - Extract expiry dates from underlying IShare objects in service layer - Add helper methods for expiry configuration (hasDefaultExpireDate, isExpireDateEnforced, getDefaultExpireDays) - Update API endpoints to accept and return expiry date information - Support setting, updating, and removing expiry dates via updateShare - Return both share data and global expiry config in getCollectiveShares Signed-off-by: Silver <s.szmajduch@posteo.de>
- Remove redundant if/else checks since getExpirationDate() returns null - Add setExpirationDate() in createShare() to reflect auto-applied expiry dates Signed-off-by: Silver <s.szmajduch@posteo.de>
silverkszlo
force-pushed
the
1566-public-shares-inherit-default-expiry-date-from-file-shares
branch
from
19476f0 to
f8e0a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Work in progress 🚧
Add ability to view and manage expiration dates on collective shares. Shares now inherit and respect Nextcloud's default expiry date policy for file shares.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)