Skip to content

fix(links): register global collectives link handler and pass it to Text#2501

Merged
mejo- merged 3 commits into
mainfrom
fix/pass_link_handler
May 18, 2026
Merged

fix(links): register global collectives link handler and pass it to Text#2501
mejo- merged 3 commits into
mainfrom
fix/pass_link_handler

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented May 12, 2026

📝 Summary

Ensures that link navigation always uses the collectives link handler, regardless of whether clicking the preview, the "Open link" button in the link bubble, or Ctrl-clicking the link directly.

Requires nextcloud/text#8571

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this May 12, 2026
@mejo- mejo- added bug Something isn't working feature: link handling labels May 12, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team May 12, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team May 12, 2026
@mejo- mejo- force-pushed the fix/pass_link_handler branch 6 times, most recently from 4607903 to b3e4330 Compare May 13, 2026 15:58
mejo- added 3 commits May 13, 2026 18:14
Ensures that link navigation always uses the collectives link handler,
regardless of whether clicking the preview, the "Open link" button in
the link bubble, or Ctrl-clicking the link directly.

Requires nextcloud/text#8571

Fixes: #2378

Signed-off-by: Jonas <jonas@freesources.org>
When `collectiveId` is accessed before `currentCollective` is loaded,
this resulted in a type error.

This was observed when running Playwright tests with UI from time to
time.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/pass_link_handler branch from b3e4330 to 7c6889a Compare May 13, 2026 16:14
@mejo- mejo- merged commit ca40b04 into main May 18, 2026
80 of 83 checks passed
@mejo- mejo- deleted the fix/pass_link_handler branch May 18, 2026 09:45
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

wrong link (if text only) in publicly sharing collective (between collectives pages)

2 participants