feat(debug): add sync type (classical or virtual) in user agent#8267
Open
feat(debug): add sync type (classical or virtual) in user agent#8267
Conversation
should enable easier debug by looking at web server access logs or server logs by just checking the user agent from desktop clients Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
Artifact containing the AppImage: nextcloud-appimage-pr-8267.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
reviewed
May 14, 2025
| switch (_syncOptions._vfs->mode()) | ||
| { | ||
| case Vfs::Off: | ||
| _account->setSynchronizationType(QStringLiteral("classical")); |
Member
There was a problem hiding this comment.
missing break
Suggested change
| _account->setSynchronizationType(QStringLiteral("classical")); | |
| _account->setSynchronizationType(QStringLiteral("classical")); | |
| break; |
nilsding
reviewed
May 14, 2025
|
|
||
| void Account::setSynchronizationType(const QString &type) | ||
| { | ||
| static_cast<AccessManager*>(_networkAccessManager.get())->setSynchronizationType(type); |
Member
There was a problem hiding this comment.
once this is set, each request will contain SyncType: classical or SyncType: virtual
I only see SyncType: account (from above) at app startup, after a proper sync that value will change through this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should enable easier debug by looking at web server access logs or server logs by just checking the user agent from desktop clients