Fix photosphere viewer not loading in NC33+#176
Conversation
|
@copilot Fix failing unit tests https://github.com/nextcloud/files_photospheres/actions/runs/25134833689/job/73670375329 |
Fixed in commit
|
|
@R0Wi is there a chance this fix can be released soon? |
Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/ddda8754-90c3-44ca-97c8-9703fbac9f52 Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
* Fix PHP controller interfaces * Remove CSP for JS eval * JS lib for modal * Update nextcloud/files and adjust registering / callback code for frontend event handler accordingly
Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/d1f3fb6c-898e-47eb-8812-29e6a650a22c Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
368d30f to
c645894
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
* Initial plan * Fix XMP metadata serialization for NC33 WebDAV client compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/ddda8754-90c3-44ca-97c8-9703fbac9f52 * fix: XmpDataReader Test signature * fix: Remove jQuery * fix: NC34 compat * Fix PHP controller interfaces * Remove CSP for JS eval * JS lib for modal * Update nextcloud/files and adjust registering / callback code for frontend event handler accordingly * Fix unit tests for NC34 API compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/d1f3fb6c-898e-47eb-8812-29e6a650a22c * Apply php-cs-fixer changes * fix: update filesAction.js.map --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
* Initial plan * Fix XMP metadata serialization for NC33 WebDAV client compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/ddda8754-90c3-44ca-97c8-9703fbac9f52 Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * fix: XmpDataReader Test signature * fix: Remove jQuery * fix: NC34 compat * Fix PHP controller interfaces * Remove CSP for JS eval * JS lib for modal * Update nextcloud/files and adjust registering / callback code for frontend event handler accordingly * Fix unit tests for NC34 API compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/d1f3fb6c-898e-47eb-8812-29e6a650a22c Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * Apply php-cs-fixer changes * fix: update filesAction.js.map --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> Co-authored-by: Robin Windey <ro.windey@gmail.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
* Master is now NC34 - Update phpunit.yml server-versions to stable34 - Update coverage.yml server-versions to stable34 - Update playwright.yml NC_REF to stable34 - Add "This version is tested for Nextcloud 34." to README.md Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/eafc5dcb-3f85-4385-bae0-ec5b17672e7d Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * Fix photosphere viewer not loading in NC33+ (#176) * Initial plan * Fix XMP metadata serialization for NC33 WebDAV client compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/ddda8754-90c3-44ca-97c8-9703fbac9f52 Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * fix: XmpDataReader Test signature * fix: Remove jQuery * fix: NC34 compat * Fix PHP controller interfaces * Remove CSP for JS eval * JS lib for modal * Update nextcloud/files and adjust registering / callback code for frontend event handler accordingly * Fix unit tests for NC34 API compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/d1f3fb6c-898e-47eb-8812-29e6a650a22c Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * Apply php-cs-fixer changes * fix: update filesAction.js.map --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> Co-authored-by: Robin Windey <ro.windey@gmail.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> Co-authored-by: Robin Windey <ro.windey@gmail.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
XmpResultModel::xmlSerialize()to write a JSON string as text content instead of XML sub-elementsfileAction.js_getDavXmpMeta()to JSON.parse the property valueenabledcheck infileAction.jsto accept both booleantrueand integer1forusePanoramaViewerXmpResultModelTest::testXmlSerialize()to expect JSON string outputPageControllerTest: update constructor call to match newPageController(IURLGenerator, IAppManager, ContentSecurityPolicyNonceManager)signature (NC34 removed$appName/$requestfrom controller constructor); remove staleunsafe-evalCSP assertionPhotosphereViewerPluginTest: replacenew File(...)/new Directory(...)withcreateMock()to avoid NC34 constructor throwingRuntimeExceptionwhen view'sgetRelativePath()returns null; fixgetId()return type fromstringtoint(?intin NC34)