Create stable34#177
Merged
Merged
Conversation
- Update phpunit.yml server-versions to stable34 - Update coverage.yml server-versions to stable34 - Update playwright.yml NC_REF to stable34 - Add "This version is tested for Nextcloud 34." to README.md Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/eafc5dcb-3f85-4385-bae0-ec5b17672e7d Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
Member
|
@copilot analyze and fix CI/CD |
Contributor
Author
Two root causes were found and fixed (commits PHPUnit failures — NC34 added Playwright directory-share failures —
|
* Initial plan * Fix XMP metadata serialization for NC33 WebDAV client compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/ddda8754-90c3-44ca-97c8-9703fbac9f52 Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * fix: XmpDataReader Test signature * fix: Remove jQuery * fix: NC34 compat * Fix PHP controller interfaces * Remove CSP for JS eval * JS lib for modal * Update nextcloud/files and adjust registering / callback code for frontend event handler accordingly * Fix unit tests for NC34 API compatibility Agent-Logs-Url: https://github.com/nextcloud/files_photospheres/sessions/d1f3fb6c-898e-47eb-8812-29e6a650a22c Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> * Apply php-cs-fixer changes * fix: update filesAction.js.map --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com> Co-authored-by: Robin Windey <ro.windey@gmail.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
R0Wi
force-pushed
the
copilot/make-app-compatible-nc34
branch
from
fbf01af to
262315d
Compare
R0Wi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the app compatible with Nextcloud 34 by updating CI workflow references, documentation, and runtime dependencies.
Changes
.github/workflows/phpunit.yml: Setserver-versionstostable34in all 3 jobs (php, mysql, pgsql).github/workflows/coverage.yml: Setserver-versionstostable34.github/workflows/playwright.yml: SetNC_REFtostable34README.md: Added "This version is tested for Nextcloud 34." linepackage.json: Updated@nextcloud/filesfrom4.0.0-rc.0to4.0.0to fix file action registration with NC34 (versioned global state scoping introduced in rc.3 makes rc.0 registrations invisible to NC34's files app)src/fileAction.js: Removednew FileAction(...)wrapper — theFileActionclass was removed in@nextcloud/files4.0.0; action objects are now passed directly toregisterFileAction()js/: Rebuilt JS assets with updated dependenciestests/Unit/Service/Helper/XmpDataReaderTest.php: Added stub implementations forgetLastActivity()andgetData(), two new abstract methods added toOCP\Files\FileInfoin NC34