fix: don't show inherited rule if there is a rule overwriting it#4714
Closed
icewind1991 wants to merge 1 commit into
Closed
fix: don't show inherited rule if there is a rule overwriting it#4714icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
hide-overwriten-inherited
branch
from
3f0885e to
c5e1dcf
Compare
Member
Author
|
Merged into #4729 |
|
NVM, didn't see the other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we always show all inherited ACLs as rules, even if there is an explicitly set rule on the same path that overwrites the inherited rule
Before:
(group "admin" has two rows)
After:
(Both screenshots with #4713 applied)