fix(acl): make preloadRulesForFolder actually warm the rule cache#4737
Open
solracsf wants to merge 1 commit into
Open
fix(acl): make preloadRulesForFolder actually warm the rule cache#4737solracsf wants to merge 1 commit into
solracsf wants to merge 1 commit into
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
bd26a07 to
9221146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACLManager::preloadRulesForFolder()was a no-op: it ran a query that scans every child of a folder and then threw the result away, caching nothing. This fixes it to populate the rule cache as intended, and speeds up the underlying query.preloadRulesForFolder()calledRuleManager::getRulesForFilesByParent()but ignored the returned array:getRulesForFilesByParent()has no caching side effect: it just builds and returns rules. So on every trash listing (TrashBackend::listTrashFolder()andgetTrashForFolders()), this query scanned every child of the folder (~20k filecache rows on a large folder) and cached nothing. The intent was clearly to warmACLManager::$ruleCacheso the subsequent per-childgetACLPermissionsForPath()calls would be cache hits.Measured ~3.6x faster for the preload query on a 15k-ACL / 20k-child folder (MariaDB 10.11), plus the per-child lookups for children that have rules are now served from cache instead of issuing a query per path.