perf(acl): share one ACLManager per user per request#4744
Open
solracsf wants to merge 1 commit into
Open
Conversation
solracsf
force-pushed
the
fix/acl-manager-factory-memoize
branch
3 times, most recently
from
5c82f56 to
b508f8c
Compare
CarlSchwan
reviewed
Jun 4, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
fix/acl-manager-factory-memoize
branch
from
b508f8c to
ba506ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4740
ACLManagerFactory::getACLManager()created a fresh ACLManager (and a fresh empty rule cache) on every call, sopreloadRulesForFolder()warmed a cache that was immediately discarded and the per-item permission checksran on different instances that never saw it.
Memoize the manager by UID. Since the factory is request-scoped, all callers now share one rule cache per user, so cache warming and the subsequent lookups actually hit the same cache.
Because the cache is now shared across all of a user's folders, scope its keys by storage id. Paths are only unique within a storage (folders using a separate storage start over at "
files/..."), so a path-only key couldotherwise return one storage's rules for a same-named path in another.
Tests:
ACLManagerFactoryTest: same UID returns the same instance; different UIDs return different instances.ACLManagerTest::testRuleCacheIsScopedPerStorage: the same relative path under two storage ids resolves with each storage's own rules (no cross-storage cache collision).