refactor: separate team folder form into own component#1093
Open
saw-jan wants to merge 22 commits into
Open
Conversation
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
commented
Jul 6, 2026
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
requested review from
Kharonus,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc and
lindenthal
as code owners
saw-jan
requested review from
Ashim-Stha,
NobodysNightmare,
nabim777,
psatyal and
wielinde
as code owners
There was a problem hiding this comment.
Pull request overview
This PR refactors the Admin Settings “Project folders (recommended)” setup UI by extracting it from AdminSettings.vue into a dedicated FormProjectFolder component, and updates the Jest test suite accordingly.
Changes:
- Extracted project folder + app-password setup flow into
src/components/admin/FormProjectFolder.vueand wired it intoAdminSettings.vue. - Centralized project-folder-related button labels in
src/constants/messages.jsand added API support for checking project folder status (getProjectFolderStatus+ endpoint). - Moved/added Jest coverage for the extracted component, including new snapshots and a shared snapshot helper.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/jest/utils.js | Adds shared snapshot serialization helper for stable IDs/uids. |
| tests/jest/components/AdminSettings.spec.js | Removes project-folder-specific tests and updates setup/reset expectations. |
| tests/jest/components/admin/FormSSOSettings.spec.js | Switches to shared snapshot serialization helper. |
| tests/jest/components/admin/FormProjectFolder.spec.js | Adds comprehensive tests for the new extracted Project Folder form component. |
| tests/jest/components/admin/snapshots/FormProjectFolder.spec.js.snap | New snapshots for the extracted component. |
| tests/jest/components/snapshots/AdminSettings.spec.js.snap | Updates snapshots due to test assertions changing from wrappers to DOM elements. |
| src/utils.js | Adds auth-method-dependent ordering metadata for the project folder form. |
| src/constants/messages.js | Adds projectFolderSetup message group for button labels. |
| src/components/AdminSettings.vue | Integrates FormProjectFolder, simplifies reset flow, removes inline project-folder setup UI. |
| src/components/admin/FormProjectFolder.vue | New extracted component implementing project folder + app password setup UI/logic. |
| src/api/settings.js | Exposes getProjectFolderStatus() API helper. |
| src/api/endpoints.js | Adds projectFolderStatus endpoint constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
PHP Code CoverageCoverage after merging refactor/split-team-folder-form into release/2.11 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separate project folder form into its own component.
UI Preview
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile