Skip to content

chore: add support of php 8.5 and remove support of php 8.2#1096

Open
nabim777 wants to merge 4 commits into
masterfrom
chore/support-php-8.5
Open

chore: add support of php 8.5 and remove support of php 8.2#1096
nabim777 wants to merge 4 commits into
masterfrom
chore/support-php-8.5

Conversation

@nabim777

@nabim777 nabim777 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR done following changes:

  • add support for php 8.5
  • remove support for php 8.2
  • update database image
  • provide the PHP version value dynamically for the PHP code summary

REF: https://docs.nextcloud.com/server/33/admin_manual/installation/system_requirements.html

Note: The current composer.lock packages not compatible with PHP 8.5 so doing composer update on php 8.5.
will get following error

Error: Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - softcreatr/jsonpath is locked to version 0.9.1 and an update of this package was not requested.
    - softcreatr/jsonpath 0.9.1 requires php 8.1 - 8.4 -> your php version (8.5.8) does not satisfy that requirement.
  Problem 2
    - helmich/phpunit-json-assert is locked to version v3.5.4 and an update of this package was not requested.
    - helmich/phpunit-json-assert v3.5.4 requires softcreatr/jsonpath ^0.8 || ^0.9 || ^1.0 -> satisfiable by softcreatr/jsonpath[0.9.1].
    - softcreatr/jsonpath 0.9.1 requires php 8.1 - 8.4 -> your php version (8.5.8) does not satisfy that requirement.

Related Issue or Workpackage

  • Fixes <issue_link>

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

nabim777 added 2 commits July 7, 2026 16:56
@nabim777
chore: add support of php 8.5 and remove support of php 8.2
e28b36c 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777
add step composer update for php8.5
9fee139 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 force-pushed the chore/support-php-8.5 branch from 41ed9a9 to 9fee139 Compare July 8, 2026 04:19
@nabim777
chore: update database image
cce8643 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@nabim777 nabim777 marked this pull request as ready for review July 8, 2026 05:48
@nabim777 nabim777 self-assigned this Jul 8, 2026
Ashim-Stha
Ashim-Stha reviewed Jul 8, 2026
View reviewed changes
Comment thread .github/workflows/shared_workflow.yml
@nabim777 nabim777 requested a review from Ashim-Stha July 8, 2026 08:26
@nabim777
chore/ci: provide php version dynamically on php code summary
75ba644 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

JS Code Coverage

Coverage after merging chore/support-php-8.5 into master will be
92.57%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js85.92%33.33%50%87.59%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js59.09%100%0%68.42%10–11, 14–15, 18–19
src/components
   AdminSettings.vue96.05%94.26%96.08%96.31%448–453, 456–461, 527–528, 532–533, 536–537, 541–542, 552–557, 588–590, 609–611, 691–693, 727–729
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue85.82%63.64%100%87.39%49–56, 64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOAuthSettings.vue97.61%96.15%93.10%98.10%217, 248, 338, 360, 378–380, 402–404
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue96.91%85.71%100%97.67%51–53
src/components/tab
   EmptyContent.vue97.98%90.91%100%98.82%102–103, 107–108
   SearchInput.vue95.31%92.96%94.74%95.78%138–139, 192, 203–208, 267–269, 285–287, 291–296
   WorkPackage.vue86.18%72.50%93.33%87.58%106–115, 128–130, 141–145, 155–157, 175–181, 219, 219–224, 224, 224–235, 80–81
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js94.68%95.24%88.89%94.76%100–102, 23–25, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.18%86.32%90.48%95.43%367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PHP Code Coverage

Coverage after merging chore/support-php-8.5 into master will be
67.90%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   ServerVersion.php0%100%0%0%17, 27–29, 32, 41–42
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php36.59%100%50%35.53%115–117, 120–124, 126–131, 133–134, 137, 142–143, 145–148, 150, 152, 154, 158–161, 163–174, 176, 179, 183, 187–189, 222
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php79.01%100%70.59%79.36%114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 577–581, 592, 606–609, 617, 621–624, 663, 669–684, 719, 722, 725–740, 754–757, 759–763
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php71.03%100%100%70.21%117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
   FilesController.php85.60%100%83.33%85.71%181–182, 244, 253, 270–273, 278–280, 285–287, 299, 301, 304
   OpenProjectAPIController.php81.09%100%82.35%80.98%116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php0%100%0%0%30, 37–38, 40–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 40–48, 50–58, 60–62, 64
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 40–43
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php88.46%100%100%87.50%62–63, 65
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php0%100%0%0%100–101, 40–42, 51–58, 60–66, 75–83, 94–99
   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner
@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner
@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner
@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner
@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner
@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal is a code owner
@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner
@saw-jan saw-jan Awaiting requested review from saw-jan saw-jan is a code owner
@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner
@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner
@Ashim-Stha Ashim-Stha Awaiting requested review from Ashim-Stha Ashim-Stha is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nabim777 nabim777

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nabim777 @Ashim-Stha