fix: incompatible AMPF with latest Nextcloud patches by saw-jan · Pull Request #1097 · nextcloud/integration_openproject

saw-jan · 2026-07-07T11:50:49Z

Description

Listen for UserLoggedInEvent event and set last-password-confirm session state if the requesting user is OpenProject and using app password

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Updated CHANGELOG.md file

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

Copilot

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds a Nextcloud event listener to work around recent server changes by updating the session’s password-confirmation timestamp when the OpenProject system user logs in via an app password/token flow.

Changes:

Introduces UserLoggedInEventListener to set last-password-confirm for OpenProject token logins
Registers the listener in the app boot sequence
Documents the fix in CHANGELOG.md

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
lib/Listener/UserLoggedInEventListener.php	New listener that updates session state on `UserLoggedInEvent` for token login
lib/AppInfo/Application.php	Wires the new listener into the event dispatcher during boot
CHANGELOG.md	Adds an entry describing the compatibility fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

come-nc

Looks good apart from registration being done in boot.

saw-jan · 2026-07-07T13:39:12Z

Tests confirmed the fix

Error:  Unexpected passed scenarios:
  - Scenario: check OpenProjectNoAutomaticProjectFolders group after user is removed from OpenProject group (removed by group admin) (tests/acceptance/features/api/teamFolder.feature:54)
  - Scenario: user not in OpenProject group is removed from another group (removed by group admin) (tests/acceptance/features/api/teamFolder.feature:63)
  - Scenario: user not in OpenProject group but has multiple group memberships is removed from one group (removed by group admin) (tests/acceptance/features/api/teamFolder.feature:78)
  - Scenario: user in OpenProject and other groups (removed by group admin) (tests/acceptance/features/api/teamFolder.feature:98)
  - Scenario: multiple user in OpenProject groups and only one gets removed (removed by group admin) (tests/acceptance/features/api/teamFolder.feature:122)
  - Scenario: user is in multiple groups including OpenProject and is removed from another group (removed by group admin) (tests/acceptance/features/api/teamFolder.feature:141)

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

github-actions · 2026-07-08T04:45:21Z

JS Code Coverage

Coverage after merging fix/incompatible-ampf into release/2.11 will be

91.28%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
bootstrap.js	0%	0%	0%	0%	1, 1, 10–12, 2–9
dashboard.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
fileActions.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–23, 3–9
personalSettings.js	0%	0%	0%	0%	1, 1, 10–19, 2–9
projectTab.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50, 6–9
reference.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
utils.js	85.92%	33.33%	50%	87.59%	12–20, 23–32
src/api
endpoints.js	100%	100%	100%	100%
settings.js	59.09%	100%	0%	68.42%	10–11, 14–15, 18–19
src/components
AdminSettings.vue	96.05%	94.26%	96.08%	96.31%	448–453, 456–461, 527–528, 532–533, 536–537, 541–542, 552–557, 588–590, 609–611, 691–693, 727–729
ErrorLabel.vue	100%	100%	100%	100%
OAuthConnectButton.vue	85.82%	63.64%	100%	87.39%	49–56, 64–69, 72–76
PersonalSettings.vue	92.02%	95.65%	90%	91.71%	133–134, 144–149, 152–161
src/components/admin
FieldValue.vue	100%	100%	100%	100%
FormAuthMethod.vue	98.12%	96.88%	100%	98.12%	222–224, 247–250
FormHeading.vue	100%	100%	100%	100%
FormOAuthSettings.vue	97.61%	96.15%	93.10%	98.10%	217, 248, 338, 360, 378–380, 402–404
FormOpenProjectHost.vue	98.87%	94.74%	100%	99.34%	167–169, 279
FormSSOSettings.vue	98.57%	97.18%	96.55%	98.91%	231–233, 242–243, 358–359
TermsOfServiceUnsigned.vue	100%	100%	100%	100%
TextInput.vue	100%	100%	100%	100%
src/components/icons
ClippyIcon.vue	100%	100%	100%	100%
OpenProjectIcon.vue	100%	100%	100%	100%
src/components/settings
CheckBox.vue	100%	100%	100%	100%
ErrorNote.vue	100%	100%	100%	100%
SettingsTitle.vue	96.91%	85.71%	100%	97.67%	51–53
src/components/tab
EmptyContent.vue	96.45%	80.95%	100%	98.24%	102–105, 107–108, 97
SearchInput.vue	95.31%	92.96%	94.74%	95.78%	138–139, 192, 203–208, 267–269, 285–287, 291–296
WorkPackage.vue	86.22%	73.17%	93.33%	87.58%	106–115, 128–130, 141–145, 155–157, 175–181, 219, 219–224, 224, 224–235, 80–81
src/constants
appID.js	100%	100%	100%	100%
links.js	100%	100%	100%	100%
messages.js	100%	100%	100%	100%
src/filesPlugin
filesPlugin.js	0%	0%	0%	0%	1, 1, 10, 100, 11–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
filesPluginLessThan28.js	0%	0%	0%	0%	1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70, 8–9
src/utils
workpackageHelper.js	93.85%	93.33%	88.89%	94.24%	100–102, 156–157, 23–25, 54, 54–56, 97–99
src/views
CreateWorkPackageModal.vue	94.18%	86.32%	90.48%	95.43%	367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
Dashboard.vue	92.96%	92.86%	82.61%	93.77%	120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
LinkMultipleFilesModal.vue	99.14%	97.56%	100%	99.32%	157–159
ProjectsTab.vue	94.06%	92.45%	93.33%	94.33%	100–101, 107–109, 129, 140–141, 175–185, 234–236, 98–99

github-actions · 2026-07-08T04:47:45Z

PHP Code Coverage

Coverage after merging fix/incompatible-ampf into release/2.11 will be

68.16%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
integration_openproject/server/apps/integration_openproject/lib
Capabilities.php	0%	100%	0%	0%	24, 31–40
OIDCClientMapper.php	0%	100%	0%	0%	29, 40–49, 52
TokenEventFactory.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
Application.php	37.04%	100%	50%	36%	116–118, 121–135, 138, 140, 142–143, 146, 151–152, 156–159, 161–172, 174, 177, 181, 185–187, 220
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
RemoveExpiredDirectUploadTokens.php	0%	100%	0%	0%	28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
ConfigController.php	79.01%	100%	70.59%	79.36%	114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 577–581, 592, 606–609, 617, 621–624, 663, 669–684, 719, 722, 725–740, 754–757, 759–763
DirectDownloadController.php	0%	100%	0%	0%	33–35, 50–52, 54–61
DirectUploadController.php	71.03%	100%	100%	70.21%	117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
FilesController.php	86.99%	100%	83.33%	87.18%	178–179, 241, 250, 267–270, 275–277, 282–284, 293
OpenProjectAPIController.php	81.09%	100%	82.35%	80.98%	116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
OpenProjectController.php	96.45%	100%	80%	96.95%	241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
OpenProjectWidget.php	0%	100%	0%	0%	101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
OpenprojectAvatarErrorException.php	100%	100%	100%	100%
OpenprojectErrorException.php	100%	100%	100%	100%
OpenprojectFileNotUploadedException.php	100%	100%	100%	100%
OpenprojectGroupfolderSetupConflictException.php	100%	100%	100%	100%
OpenprojectResponseException.php	100%	100%	100%	100%
OpenprojectUnauthorizedUserException.php	0%	100%	0%	0%	21
integration_openproject/server/apps/integration_openproject/lib/Listener
BeforeGroupDeletedListener.php	100%	100%	100%	100%
BeforeNodeInsideOpenProjectGroupfilderChangedListener.php	0%	100%	0%	0%	46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
BeforeUserDeletedListener.php	60%	100%	100%	50%	38, 42–43, 45
LoadAdditionalScriptsListener.php	0%	100%	0%	0%	37–38, 46–47, 49, 51–52, 54
LoadSidebarScript.php	65.91%	100%	100%	64.29%	105, 77–88, 95, 98
OpenProjectReferenceListener.php	0%	100%	0%	0%	45–47, 54–55, 57, 59–60, 62–74
TermsOfServiceEventListener.php	0%	100%	0%	0%	41–42, 47–48, 50–51, 53–55, 58–62
UserChangedListener.php	0%	100%	0%	0%	34, 41–42, 45–50, 53
UserLoggedInEventListener.php	0%	100%	0%	0%	27, 35–36, 39, 42
integration_openproject/server/apps/integration_openproject/lib/Migration
Version2001Date20221213083550.php	0%	100%	0%	0%	30, 40–48, 50–58, 60–62, 64
Version20100Date20250820101358.php	0%	100%	0%	0%	38, 47–53, 56
Version2310Date20230116153411.php	0%	100%	0%	0%	29, 32–35, 37–62, 64–65, 67
Version2400Date20230504144300.php	0%	100%	0%	0%	30, 40–43
Version2640Date20240628114301.php	0%	100%	0%	0%	35, 47–49, 52–53, 56
Version2900Date20250718065820.php	0%	100%	0%	0%	22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
WorkPackageReferenceProvider.php	51.67%	100%	25%	58.33%	100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
OpenProjectSearchProvider.php	0%	100%	0%	0%	100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
OpenProjectSearchResultEntry.php	100%	100%	100%	100%
integration_openproject/server/apps/integration_openproject/lib/Service
DatabaseService.php	42.31%	100%	60%	40.43%	108–112, 114, 63–76, 78–85
DirectDownloadService.php	88.46%	100%	100%	87.50%	62–63, 65
DirectUploadService.php	42.86%	100%	66.67%	40%	101, 62–65, 67–75, 95
OauthService.php	0%	100%	0%	0%	100–101, 40–42, 51–58, 60–66, 75–83, 94–99
OpenProjectAPIService.php	76.52%	100%	78.87%	76.33%	1005–1006, 1008, 1010–1011, 1034–1040,

nabim777

LGTM 👍🏻

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

fix: incompatible AMPF with latest Nextclodu patches

9d42239

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

saw-jan self-assigned this Jul 7, 2026

saw-jan changed the title ~~fix: incompatible AMPF with latest Nextclodu patches~~ fix: incompatible AMPF with latest Nextcloud patches Jul 7, 2026

chore: add changelog entry

b7607e5

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

saw-jan requested a review from Copilot July 7, 2026 11:52

NobodysNightmare reviewed Jul 7, 2026

View reviewed changes

Comment thread lib/Listener/UserLoggedInEventListener.php Outdated

NobodysNightmare reviewed Jul 7, 2026

View reviewed changes

Comment thread lib/Listener/UserLoggedInEventListener.php Outdated

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Copilot started reviewing on behalf of saw-jan July 7, 2026 12:09 View session

saw-jan force-pushed the fix/incompatible-ampf branch from 85bfee6 to 465f104 Compare July 7, 2026 12:15

chore: fix php code format

2580825

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

saw-jan force-pushed the fix/incompatible-ampf branch from 465f104 to 2580825 Compare July 7, 2026 12:18

come-nc reviewed Jul 7, 2026

View reviewed changes

Comment thread lib/AppInfo/Application.php Outdated

saw-jan added 2 commits July 8, 2026 10:27

refactor: move event listener registration inside register method

3e3de14

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

test: remove expected failure tag from passing scenarios

ba20c5c

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

saw-jan marked this pull request as ready for review July 8, 2026 04:44

saw-jan requested review from Ashim-Stha, Kharonus, ba1ash, dominic-braeunlein, individual-it, julien-nc, lindenthal, nabim777, psatyal and wielinde as code owners July 8, 2026 04:44

Ashim-Stha reviewed Jul 8, 2026

View reviewed changes

Comment thread lib/AppInfo/Application.php

nabim777 approved these changes Jul 8, 2026

View reviewed changes

saw-jan merged commit 7565291 into release/2.11 Jul 8, 2026
10 checks passed

Ashim-Stha approved these changes Jul 8, 2026

View reviewed changes

saw-jan deleted the fix/incompatible-ampf branch July 8, 2026 08:22

saw-jan mentioned this pull request Jul 8, 2026

fix: incompatible AMPF with latest Nextcloud patches #1098

Merged

saw-jan added a commit that referenced this pull request Jul 8, 2026

fix: incompatible AMPF with latest Nextcloud patches (#1097)

32f507c

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

Ashim-Stha pushed a commit that referenced this pull request Jul 8, 2026

fix: incompatible AMPF with latest Nextcloud patches (#1097) (#1098)

d86753e

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: incompatible AMPF with latest Nextcloud patches#1097

fix: incompatible AMPF with latest Nextcloud patches#1097
saw-jan merged 5 commits into
release/2.11from
fix/incompatible-ampf

saw-jan commented Jul 7, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

come-nc left a comment

Uh oh!

Uh oh!

saw-jan commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Uh oh!

nabim777 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

saw-jan commented Jul 7, 2026

Description

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

come-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saw-jan commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

JS Code Coverage

Uh oh!

github-actions Bot commented Jul 8, 2026

PHP Code Coverage

Uh oh!

Uh oh!

nabim777 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants