fix(delegation): clean delegations on user deletion#13147
Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
|
/backport to stable5.10 |
| return $this->findEntity($qb); | ||
| } | ||
|
|
||
| public function deleteByUserId(string $userId): void { |
There was a problem hiding this comment.
Should I write integration tests for the mapper ?
051990d to
b06d3e9
Compare
📝 WalkthroughWalkthrough
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f1fd5a32-4eb1-4b35-94b7-e195ef5ef64a
📒 Files selected for processing (4)
lib/Db/DelegationMapper.phplib/Listener/UserDeletedListener.phptests/Integration/Db/DelegationMapperTest.phptests/Unit/Listener/UserDeletedListenerTest.php
b06d3e9 to
1aa067b
Compare
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
1aa067b to
f3de342
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
/backport to stable5.10 please |
🤖 AI (if applicable)