refactor: migrate AdminSettings off deprecated IInitialStateService#13150
Merged
Conversation
hamza221
force-pushed
the
fix/initial-state-deprecation
branch
from
ebed5f6 to
99be09b
Compare
Member
|
nit: should be a refactor commit. The commit doesn't fix anything. It just changes the APIs used. Nothing is broken. |
hamza221
force-pushed
the
fix/initial-state-deprecation
branch
from
99be09b to
e59e32f
Compare
Use OCP\AppFramework\Services\IInitialState instead of the deprecated OCP\IInitialStateService; the app-scoped API drops the APP_ID argument. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
fix/initial-state-deprecation
branch
from
e59e32f to
fdaf0c9
Compare
hamza221
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use OCP\AppFramework\Services\IInitialState instead of the deprecated OCP\IInitialStateService; the app-scoped API drops the APP_ID argument.
Assisted-by: Claude:claude-opus-4-8
🤖 AI (if applicable)