Skip to content

feat: warn users when sending email with empty to field #13152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
steven-mpawulo wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −0
Draft

feat: warn users when sending email with empty to field #13152

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d576c90
feat: warn users when sending email with empty to field
steven-mpawulo Jun 23, 2026
0ad3191
fix: updates the warning from toast to a helper text
steven-mpawulo Jun 24, 2026
ab4cfaf
refactor: always show missing recipient warning based on To field sta…
steven-mpawulo Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/components/Composer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@
</template>
</NcSelect>
</div>
<div v-if="displayMissingToWarning">
<p class="composer-fields__helper-text">{{ t('mail', 'The email has no visible ‘To’ recipients. Some mail providers may reject this message') }}</p>
</div>
</div>
<div v-if="showCC" class="composer-fields">
<label for="cc" class="cc-label">
Expand Down Expand Up @@ -996,6 +999,10 @@
return this.mainStore.getSharedTextBlocks()?.map((textBlock) => ({ title: textBlock.title, content: textBlock.content }))
.concat(this.mainStore.getMyTextBlocks().map((textBlock) => ({ title: textBlock.title, content: textBlock.content })))
},

displayMissingToWarning() {
return this.selectTo.length === 0
},
},

watch: {
Expand Down Expand Up @@ -1024,6 +1031,7 @@
},

selectTo(val) {
this.displayMissingToWarning = false
this.$emit('update:to', val)
},

Expand Down Expand Up @@ -1539,6 +1547,7 @@
},

async onSend() {

if (this.encrypt) {
logger.debug('get encrypted message from mailvelope')
await this.$refs.mailvelopeEditor.pull()
Expand All @@ -1547,7 +1556,7 @@
this.$emit('send', {
...this.getMessageData(),
force: false,
})

Check failure on line 1559 in src/components/Composer.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Block must not be padded by blank lines
},

reset() {
Expand Down Expand Up @@ -1836,6 +1845,12 @@
-webkit-user-select: text;
user-select: text;
}

&__helper-text {
margin-top: 2px;
margin-bottom: 2px;
color: var(--color-text-error);
}
}

// Make composer editor expand
Expand Down
Loading