(Optionally) run ncp apps in tmux#796
(Optionally) run ncp apps in tmux#796theCalcaholic wants to merge 22 commits intonextcloud:develfrom
Conversation
b176ad8 to
a3c2edf
Compare
- check if tmux is availabe before attempting to start app int tmux - Attach to tmux session if app is already running
This reverts commit 8bf2d85.
|
Alright, I consider this PR complete now. Feel free to review and request changes :) |
nachoparker
left a comment
There was a problem hiding this comment.
Looks great! see some comments but in general looks great
Also, in update.sh, move /var/log/ncp.log to the new location it if exists, also update the contents of /home/www/ncp-launcher.sh
|
Looking better and better. So we are left with
I know it's in progress, just making a list |
|
@nachoparker Hm, what's missing in |
|
Like I said above ;)
|
Oh the log is already being moved in update.sh EDIT: See update.sh, line52 |
e24d3a0 to
f032fd7
Compare
75bffeb to
31d5ed9
Compare
f14678a to
0e40867
Compare
I'm still testing this, but I figured, it wouldn't hurt to create a PR for reviewing/discussing.
This implements the execution of ncp apps in tmux if 'tmux: true' i set in their config.
For most purposes, I've tried to make an app to behave exactly the same when run via tmux as it does conventionally.
Features:
when selecting an ncp app in the web interface if it is running in tmuxwhen attempting to launch an app from the web interface while one is running already