feat: frankenphp#58541
Open
CarlSchwan wants to merge 11 commits into
Open
Conversation
CarlSchwan
commented
Feb 26, 2026
CarlSchwan
force-pushed
the
carl/frankenphp
branch
from
f182ec7 to
9ff0dc1
Compare
come-nc
force-pushed
the
carl/frankenphp
branch
from
9ff0dc1 to
1d301dd
Compare
Contributor
|
https://php.watch/versions/8.3/typed-constants I need to remove type from constants 😿 |
To test: 1. Install frankenphp https://frankenphp.dev/docs/#rpm-packages 2. Install some extensions: sudo dnf in php-zts-intl php-zts-apcu php-zts-pdo_sqlite php-zts-pdo php-zts-gd php-zts-zip 3. Make /var/lib/php-zts/session writable for your user 4. `frankenphp run` This is only for the classic mode for now Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Isolated OC in its own file instead so that index.php can do finer init. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
We’re gonna need a psalm rule Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Also fixed recursive globbing and added a few manual skip. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/frankenphp
branch
from
a3f2453 to
d5ed9eb
Compare
come-nc
reviewed
Jun 2, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/frankenphp
branch
from
0255a11 to
0ddb034
Compare
come-nc
reviewed
Jun 2, 2026
come-nc
reviewed
Jun 2, 2026
come-nc
reviewed
Jun 2, 2026
| @@ -0,0 +1,49 @@ | |||
| localhost { | |||
| php_server { | |||
| worker index.php | |||
Contributor
There was a problem hiding this comment.
watch directive should be added for upgrades: https://frankenphp.dev/docs/config/#watching-for-file-changes
Member
Author
There was a problem hiding this comment.
that's already on by default
Contributor
There was a problem hiding this comment.
that's already on by default
reference needed
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Not needed in v1.12.3 Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/frankenphp
branch
from
58fbeb7 to
96f1cf8
Compare
CarlSchwan
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
Contributor
|
Caddyfile should be added in build/files-checker.php and REUSE.toml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Advantages:
To test:
frankenphp runNote that even with this PR merged, we don't recommend yet switching to frankenphp. This is preliminarily work to make it work and particularly for multi-users instance we are not yet sure that there won't be some security relevant memory sharing bugs.
TODO
Checklist
3. to review, feature component)stable32)