Skip to content

chore!(core): remove deprecated Handlebars globals #59748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Apr 24, 2026
Merged

chore!(core): remove deprecated Handlebars globals #59748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4132d7
chore!(core): remove deprecated Handlebars globals
susnux Apr 20, 2026
b993ce9
chore(assets): Recompile assets
nextcloud-command Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 9 additions & 106 deletions build/frontend-legacy/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion build/frontend-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"dompurify": "^3.4.0",
"escape-html": "^1.0.3",
"focus-trap": "^8.0.1",
"handlebars": "^4.7.8",
"is-svg": "^6.1.0",
"libphonenumber-js": "^1.12.41",
"lodash": "^4.18.1",
Expand Down
5 changes: 0 additions & 5 deletions core/src/OC/l10n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
translatePlural,
unregister,
} from '@nextcloud/l10n'
import Handlebars from 'handlebars'

/**
* L10N namespace with localization functions.
Expand Down Expand Up @@ -84,7 +83,3 @@ const L10n = {
}

export default L10n

Handlebars.registerHelper('t', function(app, text) {
return translate(app, text)
})
2 changes: 0 additions & 2 deletions core/src/globals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import ClipboardJS from 'clipboard'
import { dav } from 'davclient.js'
import Handlebars from 'handlebars'
import moment from 'moment'
import _ from 'underscore'
import { initCore } from './init.js'
Expand Down Expand Up @@ -52,7 +51,6 @@ function setDeprecatedProp(global, cb, msg) {
setDeprecatedProp(['_'], () => _, 'The global underscore is deprecated. It will be removed in a later versions without another warning. Please ship your own.')
setDeprecatedProp(['Clipboard', 'ClipboardJS'], () => ClipboardJS, 'please ship your own, this will be removed in Nextcloud 20')
setDeprecatedProp(['dav'], () => dav, 'please ship your own. It will be removed in a later versions without another warning. Please ship your own.')
setDeprecatedProp('Handlebars', () => Handlebars, 'please ship your own, this will be removed in Nextcloud 20')
setDeprecatedProp('moment', () => moment, 'please ship your own, this will be removed in Nextcloud 20')

window.OC = OC
Expand Down
4 changes: 2 additions & 2 deletions dist/core-login.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions dist/core-login.js.license
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ SPDX-FileCopyrightText: hookable developers
SPDX-FileCopyrightText: escape-html developers
SPDX-FileCopyrightText: debounce developers
SPDX-FileCopyrightText: atomiks
SPDX-FileCopyrightText: Yehuda Katz
SPDX-FileCopyrightText: Varun A P
SPDX-FileCopyrightText: Tobias Koppers @sokra
SPDX-FileCopyrightText: T. Jameson Little <t.jameson.little@gmail.com>
Expand Down Expand Up @@ -222,9 +221,6 @@ This file is generated from multiple sources. Included packages:
- focus-trap
- version: 8.0.1
- license: MIT
- handlebars
- version: 4.7.8
- license: MIT
- hookable
- version: 5.5.3
- license: MIT
Expand Down
2 changes: 1 addition & 1 deletion dist/core-login.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/core-main.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions dist/core-main.js.license
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ SPDX-FileCopyrightText: escape-html developers
SPDX-FileCopyrightText: debounce developers
SPDX-FileCopyrightText: clipboard developers
SPDX-FileCopyrightText: atomiks
SPDX-FileCopyrightText: Yehuda Katz
SPDX-FileCopyrightText: Varun A P
SPDX-FileCopyrightText: Tobias Koppers @sokra
SPDX-FileCopyrightText: Titus Wormer <tituswormer@gmail.com> (https://wooorm.com)
Expand Down Expand Up @@ -254,9 +253,6 @@ This file is generated from multiple sources. Included packages:
- focus-trap
- version: 8.0.1
- license: MIT
- handlebars
- version: 4.7.8
- license: MIT
- hookable
- version: 5.5.3
- license: MIT
Expand Down
2 changes: 1 addition & 1 deletion dist/core-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading