Skip to content

fix: track time spent in recursive markOrRun calls #59857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmart-dev wants to merge 1 commit into
base: authoritative-share-33.0.2
Choose a base branch
from
Open

fix: track time spent in recursive markOrRun calls #59857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions apps/files_sharing/lib/Listener/SharesUpdatedListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ class SharesUpdatedListener implements IEventListener {
private float $cutOffMarkTime;

/**
* The total amount of time we've spent so far processing updates
* Timestamp marking the first time this listener was triggered, used to
* determine if we should update the share date immediately or just mark the
* users for refresh.
*/
private float $updatedTime = 0.0;
private ?float $firstRun = null;
private bool $inUpdate = false;

public function __construct(
Expand Down Expand Up @@ -134,14 +136,15 @@ public function handle(Event $event): void {
}

private function markOrRun(IUser $user, callable $callback): void {
$start = floatval($this->clock->now()->format('U.u'));
if ($this->cutOffMarkTime === -1.0 || $this->updatedTime < $this->cutOffMarkTime) {
$now = floatval($this->clock->now()->format('U.u'));
$this->firstRun ??= $now;
$elapsed = $now - $this->firstRun;

if ($this->cutOffMarkTime === -1.0 && $elapsed < $this->cutOffMarkTime) {
$callback();
} else {
$this->markUserForRefresh($user);
}
$end = floatval($this->clock->now()->format('U.u'));
$this->updatedTime += $end - $start;
}

private function updateOrMarkUser(IUser $user): void {
Expand Down
Loading