fix(files): Chromium-based browsers drag-and-drop#60519
Merged
Conversation
Member
Author
|
Forgot to mention, this is related to #60139 |
susnux
reviewed
May 19, 2026
Closed
8 tasks
Contributor
seems to be related |
Member
Author
|
Fixed. Remaining cypress failures (files-renaming, live_photos, version_deletion) are pre-existing master flakes, same specs fail on unrelated PRs that don't touch the files app. |
susnux
force-pushed
the
fixChromeDragToSubFolder
branch
from
cd8b287 to
fa34f46
Compare
Contributor
|
/compile |
susnux
force-pushed
the
fixChromeDragToSubFolder
branch
2 times, most recently
from
320b6a6 to
c050a31
Compare
Contributor
|
/compile rebase |
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fixChromeDragToSubFolder
branch
from
c050a31 to
54d1c04
Compare
Contributor
|
/backport to stable33 |
Contributor
|
/backport to stable34 |
Contributor
|
/backport to stable32 |
3 tasks
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-row drop handler passed
FileSystemEntrytobatchUpload; on some Chromium builds the library'sinstanceof FileSystemFileEntrycheck fails and the entry crashes the chunk uploader withe.slice is not a function. Firefox unaffected.Route the per-row drop through
dataTransferToFileTree+onDropExternalFiles, matching the main-list drop. Converts entries to File via duck-typedentry.isFilebefore they leave this codebase.Adds three Cypress tests for the previously-uncovered per-row drop path.
Checklist
3. to review, feature component)stable32)AI (if applicable)