fix(files): fetch directory content on nested files update#60527
fix(files): fetch directory content on nested files update#60527Antreesy wants to merge 2 commits into
Conversation
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
There was a problem hiding this comment.
This should be handled by the files store not the files list.
The files list should only fetch content when the current folder is changed.
susnux
left a comment
There was a problem hiding this comment.
Node updates are handled in the files store, the list only handles updates of the current folder to refetch it because changes on folders often mean that all child nodes are invalidated.
But files are handled in the store, moreover the idea in the files app is to not fetch updates from server, this often causes performance problems because apps might change many nodes at once. Instead the files:node:updated event is for submitting your changes to a node locally so that no server requests are needed.
Meaning the real problem here is that the text app does only update the mtime but not the size when submitting the updated node:
emit('files:node:updated', node)Summary
Reproduction steps:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)