Skip to content

fix(MailPlugin): Stop applying the offset twice and the limit per wide/exact#60728

Merged
provokateurin merged 4 commits into
masterfrom
fix/mail-plugin/pagination
Jun 2, 2026
Merged

fix(MailPlugin): Stop applying the offset twice and the limit per wide/exact#60728
provokateurin merged 4 commits into
masterfrom
fix/mail-plugin/pagination

Conversation

@provokateurin
Copy link
Copy Markdown
Member

@provokateurin provokateurin commented May 26, 2026

The offset was applied twice, because it is also passed to the contacts manager for search, and the limit was applied per wide/exact and not in total.

@provokateurin provokateurin added this to the Nextcloud 35 milestone May 26, 2026
@provokateurin provokateurin requested a review from danxuliu May 26, 2026 08:33
@provokateurin provokateurin requested a review from a team as a code owner May 26, 2026 08:33
@provokateurin provokateurin requested review from ArtificialOwl and removed request for a team May 26, 2026 08:33
@provokateurin provokateurin added the 3. to review Waiting for reviews label May 26, 2026
@provokateurin
Copy link
Copy Markdown
Member Author

/backport to stable34

@provokateurin
Copy link
Copy Markdown
Member Author

/backport to stable33

Copy link
Copy Markdown
Contributor

@salmart-dev salmart-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment

Comment thread lib/private/Collaboration/Collaborators/MailPlugin.php
@provokateurin
Copy link
Copy Markdown
Member Author

I pushed again, but GH is slow...

@provokateurin provokateurin enabled auto-merge May 27, 2026 11:53
@provokateurin provokateurin force-pushed the fix/mail-plugin/pagination branch from 37cc134 to 8521e55 Compare June 1, 2026 09:03
@provokateurin
Copy link
Copy Markdown
Member Author

No changes, I just rebased to fix the GH UI.

@provokateurin provokateurin force-pushed the fix/mail-plugin/pagination branch from 8521e55 to fde8ace Compare June 1, 2026 09:44
Signed-off-by: provokateurin <kate@provokateurin.de>
…ad of calling itself

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…e/exact

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/mail-plugin/pagination branch from fde8ace to 80ec3b1 Compare June 1, 2026 12:25
@provokateurin provokateurin merged commit 0a193a3 into master Jun 2, 2026
197 of 215 checks passed
@provokateurin provokateurin deleted the fix/mail-plugin/pagination branch June 2, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants