Skip to content

[stable34] test(share20): replace addToAssertionCount checkbox tests in Share20 ManagerTest #60812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Jun 1, 2026
+4 −11
Merged

[stable34] test(share20): replace addToAssertionCount checkbox tests in Share20 ManagerTest #60812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions tests/lib/Share20/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2059,7 +2059,6 @@ public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup(): void
->willReturn([]);

self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
$this->addToAssertionCount(1);
}


Expand Down Expand Up @@ -2203,7 +2202,6 @@ public function testUserCreateChecksIdenticalPathNotSharedWithUser(): void {
->willReturn([$share2]);

self::invokePrivate($this->manager, 'userCreateChecks', [$share]);
$this->addToAssertionCount(1);
}


Expand Down Expand Up @@ -2301,7 +2299,6 @@ public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup(): void {
]);

self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
$this->addToAssertionCount(1);
}


Expand Down Expand Up @@ -2357,7 +2354,6 @@ public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup(): void
]);

self::invokePrivate($this->manager, 'groupCreateChecks', [$share]);
$this->addToAssertionCount(1);
}


Expand All @@ -2377,6 +2373,7 @@ public function testLinkCreateChecksNoLinkSharesAllowed(): void {
}


#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
public function testFileLinkCreateChecksNoPublicUpload(): void {
$share = $this->manager->newShare();

Expand All @@ -2391,7 +2388,6 @@ public function testFileLinkCreateChecksNoPublicUpload(): void {
]);

self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
$this->addToAssertionCount(1);
}

public function testFolderLinkCreateChecksNoPublicUpload(): void {
Expand All @@ -2413,6 +2409,7 @@ public function testFolderLinkCreateChecksNoPublicUpload(): void {
self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
}

#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
public function testLinkCreateChecksPublicUpload(): void {
$share = $this->manager->newShare();

Expand All @@ -2429,9 +2426,9 @@ public function testLinkCreateChecksPublicUpload(): void {
]);

self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
$this->addToAssertionCount(1);
}

#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
public function testLinkCreateChecksReadOnly(): void {
$share = $this->manager->newShare();

Expand All @@ -2448,7 +2445,6 @@ public function testLinkCreateChecksReadOnly(): void {
]);

self::invokePrivate($this->manager, 'linkCreateChecks', [$share]);
$this->addToAssertionCount(1);
}


Expand Down Expand Up @@ -2481,14 +2477,13 @@ public function testPathCreateChecksContainsNoSharedMount(): void {
$this->mountManager->method('findIn')->with('path')->willReturn([$mount]);

self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
$this->addToAssertionCount(1);
}

#[\PHPUnit\Framework\Attributes\DoesNotPerformAssertions]
public function testPathCreateChecksContainsNoFolder(): void {
$path = $this->createMock(File::class);

self::invokePrivate($this->manager, 'pathCreateChecks', [$path]);
$this->addToAssertionCount(1);
}

public static function dataIsSharingDisabledForUser() {
Expand Down Expand Up @@ -4689,7 +4684,6 @@ public function testMoveShareUser(): void {
$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);

$this->manager->moveShare($share, 'recipient');
$this->addToAssertionCount(1);
}


Expand Down Expand Up @@ -4747,7 +4741,6 @@ public function testMoveShareGroup(): void {
$this->defaultProvider->method('move')->with($share, 'recipient')->willReturnArgument(0);

$this->manager->moveShare($share, 'recipient');
$this->addToAssertionCount(1);
}

#[DataProvider('dataTestShareProviderExists')]
Expand Down
Loading