Skip to content

docs(IRequest): streamline duplicate docs + update for clarity and accuracy #60889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 15 commits into
base: master
Choose a base branch
from
+241 −316
Open

docs(IRequest): streamline duplicate docs + update for clarity and accuracy #60889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bd27741
docs(IRequest): add/update based on implementation
joshtrichards May 31, 2026
3313b5b
refactor(Request): drop docblocks already in IRequest
joshtrichards May 31, 2026
bda3209
docs(IRequest): improve the accuracy and clarity class docblock
joshtrichards May 31, 2026
fcc20b5
docs(Request): update implementation docblock properties
joshtrichards May 31, 2026
0a551a9
docs(IRequest): add missing magic properties to docblock
joshtrichards May 31, 2026
de0cd2a
docs(IRequest): correct inaccuracies and improve clarity of request p…
joshtrichards May 31, 2026
a635445
docs(IRequest): minor wording improvements to some of the simpler ret…
joshtrichards May 31, 2026
9643230
docs(IRequest): improve same-site cookie method docblocks
joshtrichards May 31, 2026
14d9019
docs(IRequest): update remaining method docblocks for accuracy and cl…
joshtrichards May 31, 2026
14cd982
chore(RequestId): drop duplicate getId docblock from implementation
joshtrichards May 31, 2026
26b28ea
docs(IRequestId): update to consistency with wrapped call in IRequest
joshtrichards May 31, 2026
9cd1557
docs(Request): add/update/cleanup internal implementation docs
joshtrichards May 31, 2026
1b4c9d3
chore(Request): drop no longer applicable psalm-baseline entries
joshtrichards May 31, 2026
8c4f852
chore(IRequest): lint/cs fixup
joshtrichards May 31, 2026
d100119
Merge branch 'master' into jtr/cleanup-Request
CarlSchwan Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3337,9 +3337,6 @@
</FalsableReturnStatement>
<NullableReturnStatement>
<code><![CDATA[$this->getOverwriteHost()]]></code>
<code><![CDATA[isset($this->cookies[$key]) ? $this->cookies[$key] : null]]></code>
<code><![CDATA[isset($this->env[$key]) ? $this->env[$key] : null]]></code>
<code><![CDATA[isset($this->files[$key]) ? $this->files[$key] : null]]></code>
</NullableReturnStatement>
<RedundantCondition>
<code><![CDATA[\is_array($params)]]></code>
Expand Down
Loading
Loading