refactor(core): move AppMenu component tree into core/src/appmenu/#60937
Draft
pringelmann wants to merge 5 commits into
Draft
refactor(core): move AppMenu component tree into core/src/appmenu/#60937pringelmann wants to merge 5 commits into
pringelmann wants to merge 5 commits into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Mounts the waffle launcher from its own entry point, independent of core-main, and exposes OC.setNavigationCounter once mounted. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
AppMenu is now mounted by its own bootstrap. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Emit the AppMenu bootstrap as its own legacy entry point so it can be loaded as a standalone core script. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Register the core/appmenu entry in the user layout so the waffle launcher mounts like every other core script. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves AppMenu (the waffle) out of
core-maininto its owncore-appmenuchunk with a small bootstrap, loaded as a normal deferred core script. Drops the oldMainMenu.jsmount since the component now owns its entry point.This ensures the waffle menu appears at the start, allowing users to switch apps immediately.
Before:
waffle_before.mp4
After:
waffle_after.mp4
Nothing changes for users, the menu renders the same.
Changes
core-appmenuwebpack entry fromcore/src/appmenu/, pulled intocorevia addScript util.setUp()call ininit.js.core/src/components/MainMenu.js.TODO
Checklist
3. to review, feature component)