refactor(dav): make chunk target resolution more explicit#60941
Draft
joshtrichards wants to merge 7 commits into
Draft
refactor(dav): make chunk target resolution more explicit#60941joshtrichards wants to merge 7 commits into
joshtrichards wants to merge 7 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Introduces a helper that replaces getUploadFile + getUploadStorage and resolves everything needed for chunk writing in one pass. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…metadata Signed-off-by: Josh <josh.t.richards@gmail.com>
… actual UploadFile Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactor makes chunk upload target resolution more explicit by replacing the old file-only path with a richer resolver that returns:
It also improves comments/docblocks around the upload lifecycle.
It is a focused internal refactor rather than a behavior change.
Core Changes
The main improvement is the new
resolveChunkWriteTarget()flow:getUploadFile()followed immediately bygetUploadStorage() which also then calledgetUploadFile()` again)isDirectflag is then used later to decide whether finalization needs copy/move.targetstaging file), but the framework is there to easily expand the "direct-to-target" write scenarios supported.The class’s actual unit of work is not just “file,” but “write target + storage + path + mode.”
Other Changes
isDirect- from the centralized resolver - is used explicitly rather than finalization code inferring mode indirectly from path comparison.$uploadFileonly forUploadFilesTODO
File/etc return typing before mergerChecklist
3. to review, feature component)stable32)AI (if applicable)