[stable34] Revert "Revert "refactor(NavigationManager): move navigation definitions into apps""#61054
Open
susnux wants to merge 2 commits into
Open
[stable34] Revert "Revert "refactor(NavigationManager): move navigation definitions into apps""#61054susnux wants to merge 2 commits into
susnux wants to merge 2 commits into
Conversation
susnux
force-pushed
the
revert-61008-revert-60961-backport/60458/stable34
branch
from
aeb54b6 to
c8edc67
Compare
Contributor
Author
|
/backport c8edc67 to master |
susnux
requested review from
artonge,
nfebe,
salmart-dev and
skjnldsv
and removed request for
a team
Contributor
Author
|
(not for 34 but .1) |
susnux
force-pushed
the
revert-61008-revert-60961-backport/60458/stable34
branch
2 times, most recently
from
6175324 to
848b521
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Why did a refactor got backported anyway? 🤔 |
Contributor
Author
Unblocking other features, because they were hard coded before. |
…on definitions into apps"" Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The `init` method previously contained two different logics: 1. It set up the internal state of default apps and app order 2. It resolved the app navigation entries The 1. is needed before `add` can be called, so it was always called by the `add` method, but this also resolved all appinfo.xml entries on the first `add` call even if never used. The 2. is only needed when the navigations are actually fetched. This splits the logic into two functions: - `init` for the bare initialization - `resolveAppNavigationEntries` for resolving the entries when requesting to output them. This should give a small performance improvement for API calls and fixes a problem when navigations are added before all apps are registered. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
revert-61008-revert-60961-backport/60458/stable34
branch
from
848b521 to
042254b
Compare
Member
That's not a valid reason to backport such changes imho |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.