fix(files_metadata): skip UpdateSingleMetadata silently for non-local owners#61066
Open
deic-cloud wants to merge 1 commit into
Open
fix(files_metadata): skip UpdateSingleMetadata silently for non-local owners#61066deic-cloud wants to merge 1 commit into
deic-cloud wants to merge 1 commit into
Conversation
… owners When a federated share is accepted, FilesMetadataManager queues UpdateSingleMetadata with the share owner's cloud ID (e.g. alice@remote.host) as the userId. getUserFolder() then throws NoUserException because the cloud ID is not a local user account. Catch NoUserException separately and skip without logging — this is an expected condition for federated shares, not an error worth warning about on every cron run. Assisted-by: ClaudeCode:claude-sonnet-4-6
deic-cloud
requested review from
Altahrim,
artonge,
leftybournes and
salmart-dev
and removed request for
a team
Collaborator
|
@deic-cloud have you checked that it is working? Psalm is complaining that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a federated share is accepted,
FilesMetadataManagerqueuesUpdateSingleMetadatawith the share owner's cloud ID (e.g.alice@remote.host) as theuserId.getUserFolder()then throwsNoUserExceptionbecause the cloud ID is not a local user account, producing a spurious warning on every cron run:This catch is added to handle
NoUserExceptionseparately and skip without logging — this is an expected condition for federated shares where the file owner lives on a remote instance, not a genuine error.Test plan
php cron.php)UpdateSingleMetadatawarning appears in the log for the federated share ownerNoUserException) still log as warningsAI assistance disclosure: fix authored with Claude Code assistance (claude-sonnet-4-6).