Skip to content

chore/use awareness#7471

Closed
max-nextcloud wants to merge 5 commits into
mainfrom
chore/use-awareness
Closed

chore/use awareness#7471
max-nextcloud wants to merge 5 commits into
mainfrom
chore/use-awareness

Conversation

@max-nextcloud

Copy link
Copy Markdown
Collaborator
  • chore(move): useDelayedFlag to composables
  • enh(status): use awareness state instead of sessions
  • fix(css): render cursor color for logged in users
  • fix(people): hide local client for guests

@max-nextcloud max-nextcloud requested a review from mejo- as a code owner July 20, 2025 12:14
@codecov

codecov Bot commented Jul 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.31250% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.08%. Comparing base (43d6213) to head (32eff67).
⚠️ Report is 169 commits behind head on main.

Files with missing lines Patch % Lines
src/extensions/CollaborationCursor.ts 16.66% 5 Missing ⚠️
src/services/PollingBackend.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7471      +/-   ##
==========================================
+ Coverage   59.76%   60.08%   +0.32%     
==========================================
  Files         494      495       +1     
  Lines       37702    37713      +11     
  Branches     1089     1087       -2     
==========================================
+ Hits        22531    22659     +128     
+ Misses      15065    14948     -117     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Css rule from notifications app was setting
```css
box-sizing: content-box;
```

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud

Copy link
Copy Markdown
Collaborator Author

It's not possible to fully rely on the awareness state - in particular as it is not authorized by the server. So it would be possible to impersonate other users etc.

I looked into various options of authorizing the information in the awareness state - but most of them result in duplicating information as we need some authorative source to check against. So let's just keep the sessions as the single point of truth with respect to who is editing the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant